feat: add EKS cluster and node group browser#183
Conversation
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR successfully adds EKS cluster and managed node group browsing capabilities to the TUI. The implementation includes comprehensive features for viewing cluster details, node group scaling configurations, and health status.
Critical Changes Required
Closure Variable Capture Issue: Both loadEKSClusters() and loadEKSNodeGroups() in internal/app/screen_eks.go capture variables outside their closure scope that should be captured inside. Move the cfg and cluster variable assignments inside the closure functions to prevent potential race conditions where the Model's state changes between closure creation and execution.
Strengths
- Clean implementation following existing TUI patterns
- Proper pagination handling for EKS API calls
- Good test coverage with mock clients
- Appropriate error handling throughout
- Well-structured UI components with filtering and navigation
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
The PR had an Amazon Q suggestion applied in a way that left nested tea.Cmd closures half-inserted, so package parsing failed before tests could run. This keeps the intended capture timing while restoring one closure per loader. Constraint: PR #183 needs go test to compile before CI can exercise EKS behavior Rejected: Revert the EKS feature branch | too broad for the localized syntax break Confidence: high Scope-risk: narrow Directive: Keep cfg and selected cluster capture inside the returned tea.Cmd closure for async model state safety Tested: env -u GOROOT go test ./... Tested: env -u GOROOT make test Tested: env -u GOROOT make build Tested: env -u GOROOT go vet ./...
2 participants
Summary
Testing
Closes #166