refactor(client): drop the Settings.watch method (RocketChat#40495)

Author: ggazzo

apps/meteor/app/ui-message/client/messageBox/messageBoxFormatting.ts

@@ -101,6 +101,6 @@ export const formattingButtons: ReadonlyArray<FormattingButton> = [
 			}
 		},
 		link: 'https://khan.github.io/KaTeX/function-support.html',
-		condition: () => settings.watch('Katex_Enabled') ?? true,
+		condition: () => settings.peek('Katex_Enabled') ?? true,
 	},
 ] as const;

apps/meteor/app/utils/client/getRoomAvatarURL.ts

@@ -4,7 +4,7 @@ import { getAvatarURL } from './getAvatarURL';
 import { settings } from '../../../client/lib/settings';
 
 export const getRoomAvatarURL = ({ roomId, cache = '' }: { roomId: IRoom['_id']; cache: IRoom['avatarETag'] }) => {
-	const externalSource = (settings.watch('Accounts_RoomAvatarExternalProviderUrl') || '').trim().replace(/\/$/, '');
+	const externalSource = (settings.peek('Accounts_RoomAvatarExternalProviderUrl') || '').trim().replace(/\/$/, '');
 	if (externalSource && typeof externalSource === 'string') {
 		return externalSource.replace('{roomId}', roomId);
 	}

apps/meteor/app/utils/client/getURL.ts

@@ -14,8 +14,8 @@ export const getURL = function (
 	cloudDeepLinkUrl?: string,
 	cacheKey?: boolean,
 ): string {
-	const cdnPrefix = settings.watch('CDN_PREFIX') || '';
-	const siteUrl = settings.watch('Site_Url') || '';
+	const cdnPrefix = settings.peek('CDN_PREFIX') || '';
+	const siteUrl = settings.peek('Site_Url') || '';
 
 	if (cacheKey) {
 		path += `${path.includes('?') ? '&' : '?'}cacheKey=${Info.version}`;

apps/meteor/app/utils/client/lib/getUserPreference.ts

@@ -43,5 +43,5 @@ export function getUserPreference<TValue>(
 	defaultValue?: TValue,
 ): TValue {
 	const user = typeof userIdOrUser === 'string' ? Users.state.get(userIdOrUser) : userIdOrUser;
-	return user?.settings?.preferences?.[key] ?? defaultValue ?? settings.watch(`Accounts_Default_User_Preferences_${key}`);
+	return user?.settings?.preferences?.[key] ?? defaultValue ?? settings.peek(`Accounts_Default_User_Preferences_${key}`);
 }

apps/meteor/app/utils/client/restrictions.ts

@@ -2,8 +2,8 @@ import { settings } from '../../../client/lib/settings';
 import { fileUploadIsValidContentTypeFromSettings } from '../lib/restrictions';
 
 export const fileUploadIsValidContentType = function (type: string | undefined, customWhiteList?: string): boolean {
-	const blackList = settings.watch<string>('FileUpload_MediaTypeBlackList') ?? 'image/svg+xml';
-	const whiteList = customWhiteList ?? settings.watch<string>('FileUpload_MediaTypeWhiteList') ?? '';
+	const blackList = settings.peek<string>('FileUpload_MediaTypeBlackList') ?? 'image/svg+xml';
+	const whiteList = customWhiteList ?? settings.peek<string>('FileUpload_MediaTypeWhiteList') ?? '';
 
 	return fileUploadIsValidContentTypeFromSettings(type, whiteList, blackList);
 };

apps/meteor/client/lib/settings/settings.ts

@@ -1,18 +1,12 @@
 import type { SettingValue } from '@rocket.chat/core-typings';
 
-import { watch } from '../../meteor/watch';
 import { PublicSettings } from '../../stores';
 
 type SettingCallback = (key: string, value: SettingValue) => void;
 
 class Settings {
 	private readonly store = PublicSettings.use;
 
-	/** Get a setting value Tracker-reactively */
-	watch<TValue = any>(_id: string): TValue | undefined {
-		return watch(this.store, (state) => state.get(_id)?.value) as TValue | undefined;
-	}
-
 	/** Get a setting value non-reactively */
 	peek<TValue = any>(_id: string): TValue | undefined {
 		return this.store.getState().get(_id)?.value as TValue | undefined;