Added language support for year progress bar by dikshaaa316 · Pull Request #52 · DhanushNehru/year-in-progress

dikshaaa316 · 2025-10-10T19:44:36Z

No description provided.

vercel · 2025-10-10T19:44:40Z

@dikshaaa316 is attempting to deploy a commit to the Dhanush Nehru's projects Team on Vercel.

A member of the Team first needs to authorize it.

DhanushNehru · 2025-10-11T06:46:00Z

Resolve merge conflict issues @dikshaaa316

Copilot

Pull Request Overview

Adds internationalization support to the year progress bar application, allowing users to select from multiple languages (English, Spanish, French, German, Hindi) with localized display text.

Added language selection dropdown with 5 language options
Implemented client-side language switching functionality
Added server-side translation support for progress bar text

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File	Description
public/index.html	Added language selector UI and JavaScript function to handle language changes
api/app.js	Added translation dictionary and localization logic for progress bar text
package.json	Updated Express version from 4.21.0 to 4.21.2

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-11T06:46:54Z

+    img.src = `http://localhost:3000/year-progress?${qs}&time=${Date.now()}`;
+  }
+</script>
+
+
    <img
      id="progress-img"
-      src="https://year-in-progress.vercel.app/year-progress"
+      src="http://localhost:3000/year-progress"


Hardcoded localhost URL should be configurable or use relative URLs for production deployment. Consider using a relative path like /year-progress?${qs}&time=${Date.now()} instead.

Copilot · 2025-10-11T06:46:54Z

+          ).src = `http://localhost:3000/year-progress?${queryString}&time=${Date.now()}&theme=${theme}`;
        } else {
          document.getElementById(
            "progress-img"
-          ).src = `https://year-in-progress.vercel.app/year-progress?time=${Date.now()}&theme=${theme}`;
+          ).src = `http://localhost:3000/year-progress?time=${Date.now()}&theme=${theme}`;


Hardcoded localhost URL should be configurable or use relative URLs for production deployment. Consider using a relative path like /year-progress?${queryString}&time=${Date.now()}&theme=${theme} instead.

Copilot · 2025-10-11T06:46:54Z

+          ).src = `http://localhost:3000/year-progress?${queryString}&time=${Date.now()}&theme=${theme}`;
        } else {
          document.getElementById(
            "progress-img"
-          ).src = `https://year-in-progress.vercel.app/year-progress?time=${Date.now()}&theme=${theme}`;
+          ).src = `http://localhost:3000/year-progress?time=${Date.now()}&theme=${theme}`;


Hardcoded localhost URL should be configurable or use relative URLs for production deployment. Consider using a relative path like /year-progress?time=${Date.now()}&theme=${theme} instead.

Copilot · 2025-10-11T06:46:54Z

        document.getElementById(
          "progress-img"
-        ).src = `https://year-in-progress.vercel.app/year-progress?${queryString}`;
+        ).src = `http://localhost:3000/year-progress?${queryString}`;


Hardcoded localhost URL should be configurable or use relative URLs for production deployment. Consider using a relative path like /year-progress?${queryString} instead.

Copilot · 2025-10-11T06:46:55Z

+    en: `Completed`,
+    es: `Completado`,
+    fr: `Terminé`,
+    de: `Abgeschlossen`,
+    hi: `पूरा हुआ`,
+  };
+
+ const localizedText = `${progressFormatted}% of ${currentYear} ${translations[lang] || translations["en"]}`;



The word order assumption may not work for all languages. Consider using a more flexible template system like ${progressFormatted}% ${translations[lang]?.template || translations.en.template} where each language can define its own sentence structure.

Suggested change

en: `Completed`,

es: `Completado`,

fr: `Terminé`,

de: `Abgeschlossen`,

hi: `पूरा हुआ`,

};

const localizedText = `${progressFormatted}% of ${currentYear} ${translations[lang] || translations["en"]}`;

en: {

template: "{progress}% of {year} Completed"

},

es: {

template: "{progress}% del {year} Completado"

},

fr: {

template: "{progress}% de {year} Terminé"

},

de: {

template: "{progress}% von {year} Abgeschlossen"

},

hi: {

template: "{year} का {progress}% पूरा हुआ"

}

};

function formatTemplate(template, values) {

return template.replace(/{(\w+)}/g, (_, key) => values[key] ?? "");

}

const template = (translations[lang]?.template) || translations["en"].template;

const localizedText = formatTemplate(template, {

progress: progressFormatted,

year: currentYear

});

dikshaaa316 · 2025-10-11T18:15:34Z

@DhanushNehru, merge conflicts are resolved.

vercel · 2025-10-13T12:02:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
year-in-progress	Ready	Preview	Comment	Oct 13, 2025 0:21am

Copilot

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-13T12:03:23Z

+    img.src = `http://localhost:3000/year-progress?${qs}&time=${Date.now()}`;
+  }
+</script>
+
+
    <img
      id="progress-img"
-      src="https://year-in-progress.vercel.app/year-progress"
+      src="http://localhost:3000/year-progress"


Hardcoded localhost URL will break in production. Consider using a relative URL or environment-based configuration.

Copilot · 2025-10-13T12:03:24Z

+    img.src = `http://localhost:3000/year-progress?${qs}&time=${Date.now()}`;
+  }
+</script>
+
+
    <img
      id="progress-img"
-      src="https://year-in-progress.vercel.app/year-progress"
+      src="http://localhost:3000/year-progress"


Hardcoded localhost URL will break in production. Consider using a relative URL like '/year-progress'.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

DhanushNehru · 2025-10-13T12:21:56Z

@dikshaaa316 do resolve the issues pointed by copilot

dikshaaa316 added 2 commits October 11, 2025 01:04

Added localization support for year progress bar

87092c6

Added language dropdown and localization feature

5f7b89e

DhanushNehru requested a review from Copilot October 11, 2025 06:46

Copilot AI reviewed Oct 11, 2025

View reviewed changes

Resolved merge conflict in public/index.html

954fed3

DhanushNehru requested a review from Copilot October 13, 2025 12:02

vercel Bot deployed to Preview October 13, 2025 12:02 View deployment

Copilot AI reviewed Oct 13, 2025

View reviewed changes

Update api/app.js

c2e5d3c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

vercel Bot deployed to Preview October 13, 2025 12:21 View deployment

-    en: `Completed`,
-    es: `Completado`,
-    fr: `Terminé`,
-    de: `Abgeschlossen`,
-    hi: `पूरा हुआ`,
-  };
- const localizedText = `${progressFormatted}% of ${currentYear} ${translations[lang] || translations["en"]}`;
+    en: {
+      template: "{progress}% of {year} Completed"
+    },
+    es: {
+      template: "{progress}% del {year} Completado"
+    },
+    fr: {
+      template: "{progress}% de {year} Terminé"
+    },
+    de: {
+      template: "{progress}% von {year} Abgeschlossen"
+    },
+    hi: {
+      template: "{year} का {progress}% पूरा हुआ"
+    }
+  };
+  function formatTemplate(template, values) {
+    return template.replace(/{(\w+)}/g, (_, key) => values[key] ?? "");
+  }
+  const template = (translations[lang]?.template) || translations["en"].template;
+  const localizedText = formatTemplate(template, {
+    progress: progressFormatted,
+    year: currentYear
+  });

Conversation

dikshaaa316 commented Oct 10, 2025

Uh oh!

vercel Bot commented Oct 10, 2025

Uh oh!

DhanushNehru commented Oct 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

dikshaaa316 commented Oct 11, 2025

Uh oh!

vercel Bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DhanushNehru commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Oct 13, 2025 •

edited

Loading