Skip to content

Improve pscloud pool CLI usability#1

Open
DhritiJindal27 wants to merge 23 commits into
mainfrom
cli_improv_azure-cli-extensions
Open

Improve pscloud pool CLI usability#1
DhritiJindal27 wants to merge 23 commits into
mainfrom
cli_improv_azure-cli-extensions

Conversation

@DhritiJindal27

@DhritiJindal27 DhritiJindal27 commented Dec 8, 2025

Copy link
Copy Markdown
Owner

Summary

This PR improves the pscloud pool CLI usability by simplifying parameter handling and removing unsupported features.

Changes

1. Removed Unsupported Identity Options

  • Removed --system-assigned and --user-assigned flags
  • These identity types are not supported by PureStorage.Block/storagePools resource type
  • Prevents confusing error messages

2. Made Required Parameters Mandatory

  • --zone / -z (availability zone)
  • --provisioned-bandwidth
  • --reservation-id
  • --subnet-id
  • --vnet-id
  • Now validated client-side before API calls for better error messages

3. Simplified VNet Configuration

  • Changed from complex --vnet-injection object to individual flags
  • Users now use --subnet-id and --vnet-id separately
  • Much more intuitive and consistent with other Azure CLI commands

4. Removed Wait Subcommand

  • Removed az pscloud pool wait command
  • Not needed and inconsistent with other Azure CLIs

5. Updated Documentation

  • Fixed examples to show correct usage with new simplified syntax

Testing

  • Verified parameter validation works correctly
  • Confirmed cleaner error messages for missing required parameters

@DhritiJindal27
Improve pscloud pool CLI usability
b9aa965 
- Rename -n and --name
- Add --zone and -z
- Flatten --vnet-injection.
- Remove unsupported identity options (--system-assigned, --user-assigned)
- Make required parameters mandatory with client-side validation
  - --zone, --provisioned-bandwidth, --reservation-id
  - --subnet-id, --vnet-id
- Remove wait subcommand for consistency with other Azure CLIs
- Update examples to show cleaner syntax with individual flags
@DhritiJindal27 DhritiJindal27 mentioned this pull request Dec 8, 2025
Open
khattartarun and others added 22 commits December 16, 2025 16:49
@khattartarun @DhritiJindal27
Removing retired service Mobile Network (Azure#9453)
b2d550e
@priyansh17 @DhritiJindal27
[dataprotection] Add support for AKS backup configuration modification (
65b003d 
Azure#9452)

* [Release] Add support for AKS backup configuration modification

* [Release] Update version to 1.8.0 and nit fixes

* azdev style fixes

* Modify AKS backup configuration parameter

* Fix typos and improve error messages for AKS backup configuration handling

* Refactor AKS backup configuration initialization

* Update AKS backup configuration argument options

* Update AKS backup instance configuration in tests
@azclibot @DhritiJindal27
[Release] Update index.json for extension [ dataprotection-1.8.0 ]
d0224af 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=145650910&view=results

Last commit: Azure@352e030
@m-chau @DhritiJindal27
[AKS] update control-plane-only user confirmation prompt (Azure#9404)
e7a2ca1
@azclibot @DhritiJindal27
[Release] Update index.json for extension [ aks-preview-19.0.0b17 ]
e2ee582 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=145675157&view=results

Last commit: Azure@d87a3e7
@FumingZhang @DhritiJindal27
{AKS} Vendor new SDK and bump API version to 2025-10-02-preview (Azur…
a22a37e 
…e#9454)

* update sdk

* update history

* update recordings
@mihretkidane-OCI @DhritiJindal27
new generated azure cli for oracle database (Azure#9435)
e6d60dc 
* new generated azure cli for oracle database

* linter exclusion

* tests and recordings

* tests and recordings

* tests and recordings

* examples

* remove secrets

* version update

* add example for db system

* add example for oracle subscription

* removed default

* removed default

* added license to new tests

* tets recordings

* tets recordings

* change logs and readme updated
@azclibot @DhritiJindal27
[Release] Update index.json for extension [ oracle-database-2.0.0 ]
a773e52 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=145871875&view=results

Last commit: Azure@cbda5a9
@ketkimnaik @ketkinaik2611 @DhritiJindal27
{IoT} Adds IoT Operations extension v2.1.0 to the index (Azure#9455)
658dab1 
Co-authored-by: Ketki <ketkinaik@microsoft.com>
@jkore1911 @DhritiJindal27
Removing hardcoded API Key (Azure#9460)
bd5c080
@mainred @DhritiJindal27
{AKS}: containerized aks-agent (Azure#9451)
38c07f5 
* cleanup evals and UTs

* add vendored_sdks

* containerized aks agent

* add UT

* update doc and release history

* fix style check errors

* update chart repo and version

* remove wrong file and update default cluster role rule

* address comments

* dont expose api key in configmap

* add init file for vendored_sdks/azure_mgmt_containerservice

* fix(windows): fix import fcntl failure on windows

* fix(windows): use tempfile library

* fix(windows): pick correct helm.exe in zip for windows

* remove unused import

* bump helm version
@azclibot @DhritiJindal27
[Release] Update index.json for extension [ aks-agent-1.0.0b12 ]
886f498 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146028638&view=results

Last commit: Azure@d08119a
@DomAyre @DhritiJindal27
[confcom] Remove the dependency on OPA (Azure#9464)
3b9cc7c 
* Remove the depedency on OPA

* Bump version

* Organise imports
@azclibot @DhritiJindal27
[Release] Update index.json for extension [ confcom ]
22a7f80 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146293397&view=results

Last commit: Azure@084bac7
@briantkim93 @briantkim-msft @DhritiJindal27
Updated Nginx version in setup (Azure#9466)
964539e 
Co-authored-by: Brian Kimutai <briankimutai@microsoft.com>
@mainred @DhritiJindal27
fix subscription id not correclty set in helm chart (Azure#9467)
d06139c
@azclibot @DhritiJindal27
[Release] Update index.json for extension [ nginx-2.0.0b9 ]
e3e4629 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146301846&view=results

Last commit: Azure@2979f01
@azclibot @DhritiJindal27
[Release] Update index.json for extension [ aks-agent-1.0.0b13 ]
bfa31d7 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146302359&view=results

Last commit: Azure@4fd8402
@itsjayway @DhritiJindal27
Update endpoint pattern regex for long TLD (Azure#9456)
590b735 
* Update endpoint pattern regex for long TLD

2,5 was too limiting for evolving customer requirements (i.e. '.microsoft'). removing the upper bound for TLD length

* change api-version to 2024-09-16-preview from 2024-09-16-preview

* updated test

* updates as per PR guidance

* remove venv

* match version witth setup.py and sort history.rst by latest first

* change release description
@azclibot @DhritiJindal27
[Release] Update index.json for extension [ footprint-1.0.1b1 ]
21b3821 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=146641489&view=results

Last commit: Azure@18bf50c
@DhritiJindal27
Update pscloud README with improved CLI syntax and removed features d…
82c82ff 
…ocumentation
@DhritiJindal27
pscloud: Release stable version 1.0.0 with CLI improvements
b26c21d 
- Updated version from 1.0.0b1 to stable 1.0.0 with dual version management
- Removed preview flags from all commands and command groups
- Fixed parameter consistency across commands (--name/-n standardization)
- Updated README documentation to reflect all parameter changes and stable version
- Added version management with separate STABLE_VERSION and PREVIEW_VERSION variables
DhritiJindal27 pushed a commit that referenced this pull request Jan 6, 2026
@mettursathish @saifaldin14
[Migrate] Start migration command, preview channel versioning & new c…
97b174d 
…ommands for replication (Azure#9493)

* Adding "Migrate" folder to the project

* Added migrate command

* Adding preview tag for commands, moving migration to a seperate folder & update help text.

* Addressing style issues

* addressing the styles and removing the duplicate key

* addressing style issues

* addesssing more style issues

* addressing  inline disable at the specific line

* Added R1702 to the pylint disable comment on the function definition.

* Addressing to disable too many nested blocks R1702

* Fixing test cases and updating version changes

* Add cli fixes (#1)

* Create extension

* Update src/migrate/azext_migrate/__init__.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix import issues

* Update src/migrate/setup.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Small

* Small lint

* Small

* disable lint for this check

* Add json

* Fix licesnse issue

* fix small

* Small

* Get rid of unused variables

* Add service name and code owner

* New version

* Style

* Small

* Update

* Follow standard

* Add suggestions

* Small

* Not preview

* Add flag to become experimental

* Update history

* Fix

* small

* Create get job and remove replication commands

* Add better error handling for jobs command

* Add better messages to remove protected item

* Return job id in remove command

* Move helpers

* Rename get discovered server helper

* Refactor _initialize_replication_infrastructure_helpers

* Refactor new replication

* Refactor jobs

* Refactor delete protected item

* Fix lint issues

* Change release version

* Fix lint issues

* Add fix

* Updae correct version

* Put beta version before

* Fix

* Update

* Fix bifurcation tool issue

* Update amh correctly if not proper

* Use current subscription id if not passed in

* Fix correct location and target resource group creation

* Create list protected items command

* Update versions

* Add __init__.py to all folders

* Create unit tests for get replication

* Update readme with accurate description of commands

* Update readme

* Create tests for jobs and remove commands

* Add more tests to increase coverage to 74%

* Add start migration command

* Address fixes

* Remove doc strings from custom.py

* Add init

* Remove old file locations

* fix failing tests

* Fix secret test

* Fix test

* Fix secret detection

* Fix duplicates

---------

Co-authored-by: Saif Al-Din Ali <saifaldinali@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Saif Al-Din Ali <saif-canada@hotmail.com>
Co-authored-by: Saif Al-Din Ali <saifaldinali@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Do Not Merge Not Yet Tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.