Skip to content

Commit 1d573c9

Browse files
author
Assistant
committed
fix(proxy): use isLoopbackHost for localhost detection
1 parent cea6e98 commit 1d573c9

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/infra/net/proxy/proxy-lifecycle.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { bootstrap as bootstrapGlobalAgent } from "global-agent";
1313
import type { ProxyConfig } from "../../../config/zod-schema.proxy.js";
1414
import { logInfo, logWarn } from "../../../logger.js";
1515
import { isLoopbackIpAddress } from "../../../shared/net/ip.js";
16+
import { isLoopbackHost } from "../../../gateway/net.js";
1617
import { forceResetGlobalDispatcher } from "../undici-global-dispatcher.js";
1718

1819
export type ProxyHandle = {
@@ -371,7 +372,7 @@ function isGatewayLoopbackControlPlaneUrl(value: string): boolean {
371372
) {
372373
return false;
373374
}
374-
return isLoopbackIpAddress(url.hostname);
375+
return isLoopbackHost(url.hostname);
375376
}
376377

377378
export function dangerouslyBypassManagedProxyForGatewayLoopbackControlPlane<T>(
@@ -389,7 +390,7 @@ export function dangerouslyBypassManagedProxyForGatewayLoopbackControlPlane<T>(
389390
savedProxyEnv[key] = process.env[key];
390391
delete process.env[key];
391392
}
392-
const lowercaseKeys = ["http_proxy", "https_proxy", "all_proxy"];
393+
const lowercaseKeys = ["all_proxy"];
393394
for (const key of lowercaseKeys) {
394395
savedProxyEnv[key] = process.env[key];
395396
delete process.env[key];

0 commit comments

Comments
 (0)