fix: Update rest session manager when logging in

If the user is not logged in when the client is created, the rest client
does not get a session manager. When the user calls login, a new session
manager is created to cache the new token but if the rest client is not
updated, any subsequent calls remain unauthenticated.

Setting the rest client's session manager to the new instance when a
login is successful means the tokens can be used without recreating the
client.

Now that the login method works as expected, the client created in the
`just repl` task can now automatically refresh its login if required.

Author: tpoliaw

justfile

@@ -40,5 +40,6 @@ repl:
     uv run --with ptpython ptpython -i <(cat << EOF
     from blueapi.client import BlueapiClient
     bc = BlueapiClient.from_config_file("tests/system_tests/config.yaml").with_instrument_session("cm12345-1")
+    bc.login()
     EOF
     )

src/blueapi/client/client.py

@@ -770,7 +770,11 @@ def login(self, token_path: Path | None = None):
                 auth = SessionManager(
                     oidc, cache_manager=SessionCacheManager(token_path)
                 )
-                auth.start_device_flow()
+                try:
+                    auth.start_device_flow()
+                    self._rest.session_manager = auth
+                except KeyboardInterrupt:
+                    pass
             else:
                 print("Server is not configured to use authentication!")
 

src/blueapi/client/rest.py

@@ -186,7 +186,7 @@ def _response_json(response: requests.Response) -> Any:
 
 class BlueapiRestClient:
     _config: RestConfig
-    _session_manager: SessionManager | None
+    session_manager: SessionManager | None
     _pool: requests.Session
 
     def __init__(
@@ -195,7 +195,7 @@ def __init__(
         session_manager: SessionManager | None = None,
     ) -> None:
         self._config = config or RestConfig()
-        self._session_manager = session_manager
+        self.session_manager = session_manager
         self._pool = requests.Session()
 
     def get_plans(self) -> PlanResponse:
@@ -315,7 +315,7 @@ def _request_and_deserialize(
                 json=data,
                 params=params,
                 headers=carr,
-                auth=JWTAuth(self._session_manager),
+                auth=JWTAuth(self.session_manager),
             )
         except requests.exceptions.ConnectionError as ce:
             raise ServiceUnavailableError() from ce