chore: revert to build pre-commit#1587
Open
ZohebShaikh wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 44 44
Lines 3254 3254
=======================================
Hits 3121 3121
Misses 133 133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Alexj9837
approved these changes
Jul 9, 2026
Alexj9837
left a comment
Contributor
There was a problem hiding this comment.
looks good. seems to be rolling back changes you made in https://github.com/DiamondLightSource/blueapi/pull/1583/changes#diff-72359463e1c50ddcb8dfabe900898a8f1d92416bbe6754f2e497f62d96232021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently docker builds work only outside of the dev container in dls workstation. So reverting this change