Skip to content

Commit 4c75587

Browse files
Merge pull request #74 from DiamondLightSource/more_ci_fixes
Fix upload/download artifacts
2 parents 2bebd66 + 30f539a commit 4c75587

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

.github/actions/install_requirements/action.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ runs:
2929

3030
- name: Create lockfile
3131
run: |
32-
mkdir -p lockfiles-${{ inputs.python_version }}
33-
pip freeze --exclude-editable > lockfiles-${{ inputs.python_version }}/${{ inputs.requirements_file }}
32+
mkdir -p lockfiles
33+
pip freeze --exclude-editable > lockfiles/${{ inputs.requirements_file }}
3434
# delete the self referencing line and make sure it isn't blank
35-
sed -i'' -e '/file:/d' lockfiles-${{ inputs.python_version }}/${{ inputs.requirements_file }}
35+
sed -i'' -e '/file:/d' lockfiles/${{ inputs.requirements_file }}
3636
shell: bash
3737

3838
- name: Upload lockfiles
@@ -49,7 +49,7 @@ runs:
4949
- name: If requirements file exists, check it matches pip installed packages
5050
run: |
5151
if [ -s ${{ inputs.requirements_file }} ]; then
52-
if ! diff -u ${{ inputs.requirements_file }} lockfiles-${{ inputs.python_version }}/${{ inputs.requirements_file }}; then
52+
if ! diff -u ${{ inputs.requirements_file }} lockfiles/${{ inputs.requirements_file }}; then
5353
echo "Error: ${{ inputs.requirements_file }} need the above changes to be exhaustive"
5454
exit 1
5555
fi

.github/workflows/code.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,20 @@ jobs:
104104
HAS_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN != '' }}
105105

106106
steps:
107-
- uses: actions/download-artifact@v4
107+
- name: Download dist
108+
uses: actions/download-artifact@v4
108109
with:
109110
pattern: dist*
110111
path: dist
111112
merge-multiple: true
112113

114+
- name: Download lockfiles
115+
uses: actions/download-artifact@v4
116+
with:
117+
pattern: lockfiles*
118+
path: lockfiles
119+
merge-multiple: true
120+
113121
- name: Fixup blank lockfiles
114122
# Github release artifacts can't be blank
115123
run: for f in lockfiles/*; do [ -s $f ] || echo '# No requirements' >> $f; done

0 commit comments

Comments
 (0)