Refactor image processing module#270
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 83.08% 83.12% +0.04%
==========================================
Files 72 75 +3
Lines 9265 9288 +23
Branches 1264 1264
==========================================
+ Hits 7698 7721 +23
Misses 1075 1075
Partials 492 492 🚀 New features to boost your workflow:
|
…processing', and updated associated imports
stephen-riggs
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image processing module has grown exceptionally large as more image registration algorithms are developed and added. The complexity of the image registration algorithms necessitates multiple helper functions, and when they are all housed within the same module, function name real estate becomes difficult to manage, and has led to function design choices that make reviewing and understanding them difficult (e.g. having multiple functions nested within the main image alignment function).
This PR refactors the image processing module into smaller sub-modules, all stored under the
cryoemservices.util.image_processingfolder. The image alignment/registration functions are each moved into their own modules, and the generic, shared functions are kept as-is, with the module being renamed asshared. The tests have been migrated to reflect this new layout as well.This PR is purely code migration, with no changes having been made to the function logic. These will be handled in subsequent PRs, as part of the effort to keep the changes scoped and understandable.