IMOD processing bypass and file copying#279
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 83.13% 83.39% +0.25%
==========================================
Files 75 75
Lines 9291 9580 +289
Branches 1264 1352 +88
==========================================
+ Hits 7724 7989 +265
- Misses 1075 1093 +18
- Partials 492 498 +6 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Jul 13, 2026
tieneupin
reviewed
Jul 13, 2026
tieneupin
reviewed
Jul 13, 2026
tieneupin
approved these changes
Jul 13, 2026
tieneupin
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! I don't think running re.match(...) on the path parts in a NumPy array is needed, but the code should work nonetheless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates imod dockerfile to include some missing libraries, then runs using
-bypassto avoid the java dependency.Also sets up a mechanism to copy the output files to a higher level. This was requested by b24 as the output folders can be messy and they want an easy way to access the tomograms.