Automatically build with(out) CUDA#34
Open
yash4karan wants to merge 10 commits into
Open
Conversation
added 10 commits
March 1, 2025 00:07
Contributor
|
So we chatted about this PR and I think since the FFS itself is rather coupled to CUDA, it might be better to make the |
dimitrivlachos
force-pushed
the
main
branch
2 times, most recently
from
2a45a62 to
fec5f87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the root
CMakeLists.txtto automatically build FFS with/without CUDA depending upon compatibility. This allows building FFS on MacOS, for example, which is a CUDA-incompatible platform.