Skip to content

Commit 44770da

Browse files
committed
remove empty dict and list defaults
1 parent 095520d commit 44770da

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

src/murfey/server/ispyb.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,9 @@ def do_update_atlas(
187187
pixel_size: float,
188188
slot: int | None,
189189
collection_mode: str | None = None,
190-
color_flags: dict[str, str | int] = {},
190+
color_flags: dict[str, str | int] | None = None,
191191
):
192+
color_flags = color_flags or {}
192193
try:
193194
with ISPyBSession() as db:
194195
atlas = db.query(Atlas).filter(Atlas.atlasId == atlas_id).one()
@@ -216,8 +217,9 @@ def do_insert_grid_square(
216217
atlas_id: int,
217218
grid_square_id: int,
218219
grid_square_parameters: GridSquareParameters,
219-
color_flags: dict[str, int] = {},
220+
color_flags: dict[str, int] | None = None,
220221
):
222+
color_flags = color_flags or {}
221223
# most of this is for mypy
222224
if (
223225
grid_square_parameters.pixel_size is not None
@@ -266,8 +268,9 @@ def do_update_grid_square(
266268
self,
267269
grid_square_id: int,
268270
grid_square_parameters: GridSquareParameters,
269-
color_flags: dict[str, int] = {},
271+
color_flags: dict[str, int] | None = None,
270272
):
273+
color_flags = color_flags or {}
271274
try:
272275
with ISPyBSession() as db:
273276
grid_square: GridSquare = (

src/murfey/workflows/clem/register_preprocessing_results.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,16 +199,17 @@ def _register_clem_image_series(
199199

200200

201201
def _get_color_flags(
202-
colors: Collection[str] = [],
202+
colors: Collection[str] | None = None,
203203
):
204+
colors = colors or []
204205
return {
205206
color_columns[color]: (1 if color in color_columns.keys() else 0)
206207
for color in colors
207208
}
208209

209210

210211
def _determine_collection_mode(
211-
colors: Collection[str] = [],
212+
colors: Collection[str] | None = None,
212213
):
213214
if not colors:
214215
logger.warning("No colours were present in returned result")

0 commit comments

Comments
 (0)