Skip to content

Match dcgs for tomo multigrid#819

Merged
stephen-riggs merged 5 commits into
mainfrom
tomo-multigrid-dm
Jun 12, 2026
Merged

Match dcgs for tomo multigrid#819
stephen-riggs merged 5 commits into
mainfrom
tomo-multigrid-dm

Conversation

@stephen-riggs

Copy link
Copy Markdown
Contributor

The data collection groups for atlas, metadata and fractions were not being matched up correctly for tomo multigrid.

This is due to the metadata being in Supervisor/Sample and the data in Supervisor_Sample

This resolves this issue by always using the metadata form with a slash. In the tomo context it checks the existence of the different metadata locations and determines the metadata_source and group_tag from this.

Also catches errors from being unable to read grid squares on a tomo atlas, and not copying the batch positions list.

@stephen-riggs stephen-riggs requested a review from d-j-hatton June 11, 2026 10:21
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.40%. Comparing base (28b4131) to head (8c02e89).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   52.39%   52.40%           
=======================================
  Files          98       98           
  Lines       10491    10509   +18     
  Branches     1385     1386    +1     
=======================================
+ Hits         5497     5507   +10     
- Misses       4705     4712    +7     
- Partials      289      290    +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/murfey/client/contexts/tomo.py Outdated
@stephen-riggs stephen-riggs merged commit 4550795 into main Jun 12, 2026
17 checks passed
@stephen-riggs stephen-riggs deleted the tomo-multigrid-dm branch June 12, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants