Skip to content

Allow installation for python 3.6#51

Merged
thomascobb merged 1 commit into
masterfrom
allow-3.6
Oct 15, 2021
Merged

Allow installation for python 3.6#51
thomascobb merged 1 commit into
masterfrom
allow-3.6

Conversation

@EmilioPeJu

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Oct 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #51 (5bfef85) into master (59d87d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files          13       13           
  Lines         832      832           
=======================================
  Hits          712      712           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d87d0...5bfef85. Read the comment docs.

@AlexanderWells-diamond

Copy link
Copy Markdown
Collaborator

If you're doing this I expect you'll need to add 3.6 to the CI runs as well? We test with all the other supported versions.

You may not want to/be able to until PR #49 is merged though, as that contains a lot of CI changes from Tom at the moment.

@EmilioPeJu

Copy link
Copy Markdown
Contributor Author

It looks like I broke some tests, I'll investigate the best way to fix it

@EmilioPeJu

EmilioPeJu commented Oct 12, 2021

Copy link
Copy Markdown
Contributor Author

It's actually a problem in aioca with: from __future__ import annotations
I'm tempted to remove that line.

@thomascobb

Copy link
Copy Markdown
Contributor

Sounds reasonable, if you add python 3.6 to the aioca build matrix then we'll know if that's all that needs changing...

@EmilioPeJu EmilioPeJu closed this Oct 14, 2021
@EmilioPeJu EmilioPeJu reopened this Oct 14, 2021
@EmilioPeJu

EmilioPeJu commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

Given that DiamondLightSource/aioca#19 was merged, this change is easier, though it will have to wait for next release

@thomascobb

Copy link
Copy Markdown
Contributor

aioca 1.3 is now released for Python 3.6

@EmilioPeJu

Copy link
Copy Markdown
Contributor Author

Thanks Tom, I added the version constraint for aioca and CI looks happy now

@thomascobb thomascobb merged commit ce6d3b3 into master Oct 15, 2021
@thomascobb thomascobb deleted the allow-3.6 branch October 15, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants