V1 Done and working by Trubador · Pull Request #5 · DidactHQ/didact-engine

Trubador · 2024-09-20T15:34:43Z

No description provided.

Trubador · 2025-01-14T23:51:56Z

@DMiradakis Any update to my Pull Request? - is it obsolete by now?

Fix foreign key constraint on FlowRun table

--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Trubador/didact-engine?shareId=XXXX-XXXX-XXXX-XXXX).

Fix foreign key constraint issue in FlowRun table

CLAassistant · 2025-02-01T21:24:01Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

- Introduced ExecutionMode entity and updated related configurations. - Added FlowRunRepository for managing flow runs. - Updated database context to include ExecutionModes DbSet. - Refactored database initialization logic to seed ExecutionModes. - Updated application to use SQLite as the default database provider. - Enhanced error handling and logging in various components.

Copilot

Pull Request Overview

This PR implements the initial V1 version of the Didact workflow engine with a complete working system. The engine transitions from SQL Server to SQLite for local development and adds core functionality for flow management, execution scheduling, and background processing.

Key changes:

Migrated database provider from SQL Server to SQLite with proper configuration handling
Implemented comprehensive flow and flow run management with repositories and controllers
Enhanced task scheduling with efficient thread pool management and graceful shutdown capabilities

Reviewed Changes

Copilot reviewed 51 out of 69 changed files in this pull request and generated 16 comments.

Show a summary per file

File	Description
DidactEngine/appsettings.json	Database configuration updated to support SQLite for local development
DidactEngine/TaskSchedulers/DidactThreadPoolScheduler.cs	Enhanced thread pool scheduler with proper synchronization and shutdown handling
DidactEngine/Services/FlowRunRepository.cs	New repository for flow run CRUD operations
DidactEngine/Services/FlowRepository.cs	New repository for flow management and configuration storage
DidactEngine/Services/Database/DatabaseInitializer.cs	Database initialization service with seeding capabilities
DidactEngine/Services/Contexts/DidactDbContext.cs	Database context updated for SQLite compatibility
DidactEngine/Program.cs	Application startup configuration with dependency injection setup

Files not reviewed (17)

.idea/.idea.DidactEngine/.idea/.gitignore: Language not supported
.idea/.idea.DidactEngine/.idea/.name: Language not supported
.idea/.idea.DidactEngine/.idea/indexLayout.xml: Language not supported
.idea/.idea.DidactEngine/.idea/vcs.xml: Language not supported
DidactEngine/Migrations/20230717051620_InitialSnapshot.Designer.cs: Language not supported
DidactEngine/Migrations/20231205064918_RenamedStandardQueuesToHyperQueues.Designer.cs: Language not supported
DidactEngine/Migrations/20231206055336_AddFlowRunsConfigurations.Designer.cs: Language not supported
DidactEngine/Migrations/20231206071100_AddFlowRunsToQueueInbounds.Designer.cs: Language not supported
DidactEngine/Migrations/20231209040238_RemoveFlowRefsFromQueueInboundConfigurations.Designer.cs: Language not supported
DidactEngine/Migrations/20231209041434_AddWhoAuditColumnsToOrganization.Designer.cs: Language not supported
DidactEngine/Migrations/20231209044908_AddBlockRunConfig.Designer.cs: Language not supported
DidactEngine/Migrations/20231210080814_AddEngineConfiguration.Designer.cs: Language not supported
DidactEngine/Migrations/20231210081256_AddEngineUniqueNameConstraint.Designer.cs: Language not supported
DidactEngine/Migrations/20231210202046_AddFlowNameUniqueConstraint.Designer.cs: Language not supported
DidactEngine/Migrations/20240107100141_AddTypeRefToFlow.Designer.cs: Language not supported
DidactEngine/Migrations/20250604162806_InitialCreate.Designer.cs: Language not supported
DidactEngine/Migrations/20250604165914_AddExecutionModesDbSet.Designer.cs: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-14T20:04:09Z

  "AllowedHosts": "*",
  "ConnectionStrings": {
-    "Didact": "Data Source=localhost;Initial Catalog=Didact;Integrated Security=true"
+    "Didact": "Data source=localhost;Initial Catalog=Didact;User Id=sa;Password=9b9i!B8PJrec56rEo@T8T3LB#5a3rnaKd@m?hBcP;" // running in docker sql server container


Database password is exposed in plain text in the configuration file. Consider using environment variables, user secrets, or a secure configuration provider for sensitive connection string information.

Suggested change

"Didact": "Data source=localhost;Initial Catalog=Didact;User Id=sa;Password=9b9i!B8PJrec56rEo@T8T3LB#5a3rnaKd@m?hBcP;" // running in docker sql server container

"Didact": "Data source=localhost;Initial Catalog=Didact;User Id=sa;Password=${DIDACT_DB_PASSWORD};" // running in docker sql server container; set DIDACT_DB_PASSWORD as an environment variable

Copilot · 2025-09-14T20:04:09Z

-        private readonly ThreadLocal<string> _currentThreadName = new();
-
-        private readonly int _maxDegreeOfParallelism;
+        private readonly ThreadLocal<bool> _currentThreadIsExecuting = new(false);        private readonly ThreadLocal<string> _currentThreadName = new();


[nitpick] Multiple field declarations should be on separate lines for better readability and maintainability.

Copilot · 2025-09-14T20:04:09Z

-        public DidactThreadPoolScheduler(ILogger<DidactThreadPoolScheduler> logger, int maxDegreeOfParallelism)
+        private readonly AutoResetEvent _workAvailable = new(false);
+
+        private volatile bool _shutdown = false;        public DidactThreadPoolScheduler(ILogger<DidactThreadPoolScheduler> logger, int maxDegreeOfParallelism)


[nitpick] Field declaration and constructor should be on separate lines for better code readability.

Copilot · 2025-09-14T20:04:10Z

-        }
-
-        private void ThreadExecutionLoop()
+        }        private void ThreadExecutionLoop()


[nitpick] Missing line break between method declarations. Add proper spacing for better code readability.

Copilot · 2025-09-14T20:04:10Z

+                        // This blocks the thread instead of busy-waiting, dramatically reducing CPU usage
+                        _workAvailable.WaitOne(1000); // Wait up to 1 second for work
+                    }
+                }                catch (ThreadInterruptedException ex)


[nitpick] Missing line break between closing brace and catch block. Add proper spacing for better code readability.

Copilot · 2025-09-14T20:04:12Z

+        private async Task SeedInitialDataAsync()
+        {            // Add any initial seeding logic here
+            // For example, ensure there's at least one organization            if (!await _dbContext.Organizations.AnyAsync())


[nitpick] Inconsistent indentation and formatting in comments and code. Ensure proper line breaks and consistent spacing.

Copilot · 2025-09-14T20:04:12Z

+        {            // Add any initial seeding logic here
+            // For example, ensure there's at least one organization            if (!await _dbContext.Organizations.AnyAsync())
+            {                _dbContext.Organizations.Add(new DidactCore.Entities.Organization


[nitpick] Inconsistent indentation. The opening brace should be properly aligned with the if statement.

Suggested change

{ // Add any initial seeding logic here

// For example, ensure there's at least one organization if (!await _dbContext.Organizations.AnyAsync())

{ _dbContext.Organizations.Add(new DidactCore.Entities.Organization

{

// Add any initial seeding logic here

// For example, ensure there's at least one organization

if (!await _dbContext.Organizations.AnyAsync())

{

_dbContext.Organizations.Add(new DidactCore.Entities.Organization

Copilot · 2025-09-14T20:04:12Z

-            _flowExecutor = flowExecutor ?? throw new ArgumentNullException(nameof(flowExecutor));
+            //_flowRepository = flowRepository ?? throw new ArgumentNullException(nameof(flowRepository));
+            //_flowExecutor = flowExecutor ?? throw new ArgumentNullException(nameof(flowExecutor));
        }


Extra closing brace at the end of file that doesn't match any opening brace.

Copilot · 2025-09-14T20:04:13Z

+using Microsoft.Extensions.DependencyInjection;
+using DidactEngine.Services;
+using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Hosting;


Duplicate using statement for Microsoft.Extensions.Hosting should be removed.

Suggested change

using Microsoft.Extensions.Hosting;

Copilot · 2025-09-14T20:04:13Z

+        /// </summary>
+        /// <returns></returns>
+        [HttpPost("/flows")]
+        [SwaggerResponse(StatusCodes.Status202Accepted)]        public async Task<IActionResult> CreateFlowAsync()


[nitpick] Missing line break between attribute and method declaration. Add proper spacing for better code readability.

Suggested change

[SwaggerResponse(StatusCodes.Status202Accepted)] public async Task<IActionResult> CreateFlowAsync()

[SwaggerResponse(StatusCodes.Status202Accepted)]

public async Task<IActionResult> CreateFlowAsync()

Trubador added 6 commits August 11, 2024 22:21

V1 done

7f87e7a

Lots of improvements

33e842c

clean up

68e945d

removed password secret

c19670c

Create main.yml

72b5f57

Create Dockerfile

02a7a4a

Trubador added 9 commits January 28, 2025 00:01

Fix foreign key constraint on FlowRun table

ef02b17

Merge pull request #1 from Trubador/fix-foreign-key-constraint

4bcae92

Fix foreign key constraint on FlowRun table

Normalize line endings

5cb64b7

Save local changes before pulling

f80cd7a

fixes

c8426fe

fix

4792e4d

small fix

ee0f204

Fix foreign key constraint issue in FlowRun table

4764603

--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Trubador/didact-engine?shareId=XXXX-XXXX-XXXX-XXXX).

Merge pull request #2 from Trubador/fix-foreign-key-constraint

756a9c6

Fix foreign key constraint issue in FlowRun table

Copilot AI review requested due to automatic review settings September 14, 2025 20:01

Copilot AI reviewed Sep 14, 2025

View reviewed changes

	"Didact": "Data source=localhost;Initial Catalog=Didact;User Id=sa;Password=9b9i!B8PJrec56rEo@T8T3LB#5a3rnaKd@m?hBcP;" // running in docker sql server container
	"Didact": "Data source=localhost;Initial Catalog=Didact;User Id=sa;Password=${DIDACT_DB_PASSWORD};" // running in docker sql server container; set DIDACT_DB_PASSWORD as an environment variable

	[SwaggerResponse(StatusCodes.Status202Accepted)] public async Task<IActionResult> CreateFlowAsync()
	[SwaggerResponse(StatusCodes.Status202Accepted)]
	public async Task<IActionResult> CreateFlowAsync()

Uh oh!

Conversation

Trubador commented Sep 20, 2024

Uh oh!

Trubador commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Feb 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Trubador commented Jan 14, 2025 •

edited

Loading

CLAassistant commented Feb 1, 2025 •

edited

Loading