return 0 on success

Author: tomdaley92

shared/profiles.c

@@ -33,17 +33,17 @@ static void bytes_to_hex(const uint8_t *bytes, char *hex_out, size_t dst_size) {
 }
 
 /* Decode a 64-character hex string into a 32-byte SHA-256 digest.
- * Returns 1 on success, 0 if any byte fails to parse. */
+ * Returns 0 on success, non-zero on failure. */
 static int sha256_hex_to_bytes(const char *hex_str, sha256_hash_t *out) {
     for (int i = 0; i < 32; i++) {
         unsigned int byte;
         if (sscanf(hex_str + i*2, "%2x", &byte) != 1) {
             printf("Warning: Invalid hex byte at offset %d in SHA256: %s\n", i*2, hex_str);
-            return 0;
+            return 1;
         }
         out->bytes[i] = (uint8_t)byte;
     }
-    return 1;
+    return 0;
 }
 
 /* Trim leading and trailing whitespace from str in-place. */
@@ -55,14 +55,15 @@ static void trim_whitespace(char *str) {
     while (len > 0 && isspace((unsigned char)str[len - 1])) str[--len] = '\0';
 }
 
-/* Create an empty profiles.ini with a comment header. Returns 1 on success. */
+/* Create an empty profiles.ini with a comment header.
+ * Returns 0 on success, non-zero on failure. */
 static int create_profiles_ini(const char *path) {
     FILE *file = fopen(path, "w");
-    if (!file) return 0;
+    if (!file) return 1;
     fprintf(file, "# ROM Profiles Database\n");
     fprintf(file, "# Format: [SHA256] followed by quirk settings\n\n");
     fclose(file);
-    return 1;
+    return 0;
 }
 
 /* Flush a completed profile entry into the hashmap. No-op if has_current is 0. */
@@ -76,12 +77,12 @@ static void commit_pending_profile(int has_current, const sha256_hash_t *sha256,
 
 /* Parse a section-header line of the form [SHA256] or [0xSHA256] (case-insensitive).
  * Writes the decoded 32-byte hash into *sha256_out.
- * Returns 1 on success, 0 on any parse or validation error. */
+ * Returns 0 on success, non-zero on any parse or validation error. */
 static int parse_section_header(const char *line, sha256_hash_t *sha256_out) {
     char inner[128];
     if (sscanf(line, "[%127[^]]]", inner) != 1) {
         printf("Warning: Malformed section header: %s\n", line);
-        return 0;
+        return 1;
     }
 
     /* Skip optional "0x" / "0X" prefix */
@@ -92,7 +93,7 @@ static int parse_section_header(const char *line, sha256_hash_t *sha256_out) {
     if (strlen(hex_start) != 64) {
         printf("Warning: SHA256 must be 64 hex characters (got %zu): %s\n",
                strlen(hex_start), hex_start);
-        return 0;
+        return 1;
     }
 
     return sha256_hex_to_bytes(hex_start, sha256_out);
@@ -145,7 +146,7 @@ static void parse_profiles_ini(void) {
             commit_pending_profile(has_current, &current_sha256, &current_profile);
 
             sha256_hash_t parsed_sha256;
-            if (!parse_section_header(line, &parsed_sha256)) {
+            if (parse_section_header(line, &parsed_sha256) != 0) {
                 has_current = 0;
                 continue;
             }
@@ -184,24 +185,25 @@ static void build_default_search_paths(char paths[2][LINE_MAX]) {
 }
 
 /* Search candidate paths for an existing readable profiles.ini.
- * On success, copies the found path into loaded_profiles_path and returns 1. */
+ * On success, copies the found path into loaded_profiles_path and returns 0.
+ * Returns non-zero if no candidate exists. */
 static int find_existing_profiles_file(char candidates[2][LINE_MAX]) {
     for (int i = 0; i < 2; i++) {
         FILE *file = fopen(candidates[i], "r");
         if (file) {
             fclose(file);
             set_path(loaded_profiles_path, sizeof(loaded_profiles_path), candidates[i]);
-            return 1;
+            return 0;
         }
     }
-    return 0;
+    return 1;
 }
 
 /* Locate or create profiles.ini, populating loaded_profiles_path.
  * If a custom path was set by profiles_init(), honour it exclusively.
  * Otherwise, search next to the executable and in macOS bundle Resources,
  * creating a new file in the first candidate location if none is found.
- * Returns 1 if an existing file is ready to be parsed, 0 otherwise. */
+ * Returns 0 on success, non-zero on failure. */
 static int resolve_profiles_path(void) {
     char msg[TOAST_MSG_MAX];
 
@@ -213,42 +215,46 @@ static int resolve_profiles_path(void) {
             snprintf(msg, sizeof(msg), "ROM profiles: %s", loaded_profiles_path);
             toast_show(TOAST_INFO, msg);
             printf("%s\n", msg);
-            return 1;
+            return 0;
         }
         /* File does not exist yet — create it */
-        if (create_profiles_ini(loaded_profiles_path)) {
+        if (create_profiles_ini(loaded_profiles_path) == 0) {
             snprintf(msg, sizeof(msg), "ROM profiles created: %s", loaded_profiles_path);
             toast_show(TOAST_SUCCESS, msg);
+            printf("%s\n", msg);
+            return 0;
         } else {
             snprintf(msg, sizeof(msg), "Failed to create: %s", loaded_profiles_path);
             toast_show(TOAST_ERROR, msg);
+            printf("%s\n", msg);
+            return 1;
         }
-        printf("%s\n", msg);
-        return 0;
     }
 
     /* --- Default search paths --- */
     char search_paths[2][LINE_MAX];
     build_default_search_paths(search_paths);
 
-    if (find_existing_profiles_file(search_paths)) {
+    if (find_existing_profiles_file(search_paths) == 0) {
         snprintf(msg, sizeof(msg), "ROM profiles: %s", loaded_profiles_path);
         toast_show(TOAST_INFO, msg);
         printf("%s\n", msg);
-        return 1;
+        return 0;
     }
 
     /* --- Not found: create at the first candidate path --- */
-    if (create_profiles_ini(search_paths[0])) {
+    if (create_profiles_ini(search_paths[0]) == 0) {
         set_path(loaded_profiles_path, sizeof(loaded_profiles_path), search_paths[0]);
         snprintf(msg, sizeof(msg), "ROM profiles created: %s", search_paths[0]);
         toast_show(TOAST_INFO, msg);
+        printf("%s\n", msg);
+        return 0;
     } else {
         snprintf(msg, sizeof(msg), "Failed to create: %s", search_paths[0]);
         toast_show(TOAST_ERROR, msg);
+        printf("%s\n", msg);
+        return 1;
     }
-    printf("%s\n", msg);
-    return 0;
 }
 
 void profiles_init(const char *custom_path) {
@@ -257,7 +263,7 @@ void profiles_init(const char *custom_path) {
     if (custom_path && custom_path[0] != '\0') {
         set_path(loaded_profiles_path, sizeof(loaded_profiles_path), custom_path);
     }
-    if (resolve_profiles_path()) {
+    if (resolve_profiles_path() == 0) {
         parse_profiles_ini();
     }
 }
@@ -281,16 +287,16 @@ const struct profile* profile_lookup(const sha256_hash_t *sha256) {
 /* Rewrite the entire profiles.ini from the in-memory hashmap.
  * The file is fully replaced on each save rather than appended,
  * which keeps the format clean and avoids duplicate entries. */
-static void profiles_write_to_file(void) {
+static int profiles_write_to_file(void) {
     if (loaded_profiles_path[0] == '\0') {
         printf("Error: profiles.ini path not initialized\n");
-        return;
+        return 1;
     }
 
     FILE *file = fopen(loaded_profiles_path, "w");
     if (!file) {
         printf("Error: Unable to write to %s\n", loaded_profiles_path);
-        return;
+        return 1;
     }
 
     fprintf(file, "# ROM Profiles Database\n");
@@ -310,17 +316,18 @@ static void profiles_write_to_file(void) {
     }
 
     fclose(file);
+    return 0;
 }
 
-void profiles_save(const uint8_t *rom, size_t rom_size, const char *rom_name,
-                   const struct quirks *quirks) {
+int profiles_save(const uint8_t *rom, size_t rom_size, const char *rom_name,
+                  const struct quirks *quirks) {
     if (!rom || rom_size == 0 || !rom_name || !quirks) {
         toast_show(TOAST_ERROR, "No ROM loaded. Cannot save profile.");
-        return;
+        return 1;
     }
     if (loaded_profiles_path[0] == '\0') {
         toast_show(TOAST_ERROR, "Could not locate profiles.ini");
-        return;
+        return 1;
     }
 
     sha256_hash_t sha256;
@@ -332,12 +339,16 @@ void profiles_save(const uint8_t *rom, size_t rom_size, const char *rom_name,
     p.quirks = *quirks;
 
     hmput(profile_map, sha256, p);
-    profiles_write_to_file();
+    if (profiles_write_to_file() != 0) {
+        toast_show(TOAST_ERROR, "Failed to write profiles.ini");
+        return 1;
+    }
 
     char hash_hex[65];
     bytes_to_hex(sha256.bytes, hash_hex, sizeof(hash_hex));
     printf("Saved ROM profile for: %s (SHA256: %s)\n", rom_name, hash_hex);
     char msg[TOAST_MSG_MAX];
     snprintf(msg, sizeof(msg), "Profile saved: %s", rom_name);
     toast_show(TOAST_SUCCESS, msg);
+    return 0;
 }

shared/profiles.h

@@ -28,9 +28,10 @@ const struct profile* profile_lookup(const sha256_hash_t *sha256);
 
 /* Save a ROM's quirks to the profile database and INI file.
  * rom_name should be the display name or basename stored in the profile.
- * Also adds the profile to the runtime hashmap immediately. */
-void profiles_save(const uint8_t *rom, size_t rom_size, const char *rom_name,
-                   const struct quirks *quirks);
+ * Also adds the profile to the runtime hashmap immediately.
+ * Returns 0 on success, non-zero on failure. */
+int profiles_save(const uint8_t *rom, size_t rom_size, const char *rom_name,
+                  const struct quirks *quirks);
 
 #ifdef __cplusplus
 }