Add domain property to entity proxies#172
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a domain property to entity proxies in the Synapse library to facilitate filtering entities by their domain type (e.g., "sensor", "binary_sensor", "switch").
Changes:
- Added a
domaingetter to entity proxies that returns the entity's domain string - Updated type definitions to include the domain property in CommonMethods type signature
- Added comprehensive test coverage for all entity types
- Updated dependencies (unrelated to the feature)
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/generator.service.mts | Added "domain" to proxy keys and implemented domain property getter |
| src/helpers/common-config.mts | Added domain property to CommonMethods type with ExtractDomain helper |
| src/test/generator.spec.mts | Added comprehensive tests for domain property across all entity types |
| package.json | Updated dependency versions (unrelated dependency updates) |
| yarn.lock | Lock file updates corresponding to package.json changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📬 Changes
domainproperty to aid in filtering synapse entities🗒️ Checklist
code of conduct