Fix/nitro gql fragments#499
Open
freality wants to merge 3 commits into
Open
Conversation
Rewrite #gql-nitro to import getSdk instead of generating its own code. This resolves the issue of fragment errors when executing gql functions in server handlers.
Owner
|
@freality I'd be happy to merge this once it's modified to properly support multiple clients, the current implementation is only for the default client if one is specified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rewrote the
#gql-nitrovirtual code toimport { getSdk } from '#gql/default'instead of generating gql docs from theclientSdkscode which excludes fragment definitions.I've found no issues with this approach. And this solution fixes #333.