Skip to content

Commit 10dbe81

Browse files
committed
Fix SetInlineConstants: Do NOT call UpdateRevision()
1 parent c61d4ef commit 10dbe81

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

Graphics/GraphicsEngineOpenGL/include/ShaderResourceCacheGL.hpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,10 @@ class ShaderResourceCacheGL : public ShaderResourceCacheBase
399399
VERIFY(CacheOffset < GetUBCount(), "Cache offset is out of range");
400400
CachedUB& UB = GetUB(CacheOffset);
401401
UB.SetInlineConstants(pConstants, FirstConstant, NumConstants);
402-
UpdateRevision();
402+
// NOTE: Do NOT call UpdateRevision() here.
403+
// Inline constants are allowed to change after SRB commit without re-committing.
404+
// The InlineConstantsSRBMask and InlineConstantsIntact flag handle the update logic.
405+
// This is consistent with D3D11 and Vulkan implementations.
403406
}
404407

405408
void CopyInlineConstants(const ShaderResourceCacheGL& SrcCache,

0 commit comments

Comments
 (0)