Rework super-resolution validation

Author: MikhailGorobets

Graphics/SuperResolution/include/SuperResolutionBase.hpp

@@ -39,6 +39,8 @@ namespace Diligent
 
 #define LOG_SUPER_RESOLUTION_ERROR_AND_THROW(Name, ...) LOG_ERROR_AND_THROW("Super resolution upscaler '", ((Name) != nullptr ? (Name) : ""), "': ", ##__VA_ARGS__)
 
+#define DEV_CHECK_SUPER_RESOLUTION(Name, Expr, ...) DEV_CHECK_ERR(Expr, "Super resolution upscaler '", ((Name) != nullptr ? (Name) : ""), "': ", ##__VA_ARGS__)
+
 #define VERIFY_SUPER_RESOLUTION(Name, Expr, ...)                     \
     do                                                               \
     {                                                                \
@@ -48,22 +50,24 @@ namespace Diligent
         }                                                            \
     } while (false)
 
+
+
 /// Validates super resolution description and throws an exception in case of an error.
 void ValidateSuperResolutionDesc(const SuperResolutionDesc& Desc) noexcept(false);
 
 /// Validates super resolution description for temporal upscaling and throws an exception in case of an error.
 void ValidateTemporalSuperResolutionDesc(const SuperResolutionDesc& Desc) noexcept(false);
 
-/// Validates super resolution source settings attributes and throws an exception in case of an error.
-void ValidateSourceSettingsAttribs(const SuperResolutionSourceSettingsAttribs& Attribs) noexcept(false);
+/// Validates super resolution source settings attributes using DEV checks.
+void ValidateSourceSettingsAttribs(const SuperResolutionSourceSettingsAttribs& Attribs);
 
-/// Validates execute super resolution attributes and throws an exception in case of an error.
+/// Validates execute super resolution attributes using DEV checks.
 void ValidateExecuteSuperResolutionAttribs(const SuperResolutionDesc&           Desc,
-                                           const ExecuteSuperResolutionAttribs& Attribs) noexcept(false);
+                                           const ExecuteSuperResolutionAttribs& Attribs);
 
-/// Validates execute super resolution attributes for temporal upscaling and throws an exception in case of an error.
+/// Validates execute super resolution attributes for temporal upscaling using DEV checks.
 void ValidateTemporalExecuteSuperResolutionAttribs(const SuperResolutionDesc&           Desc,
-                                                   const ExecuteSuperResolutionAttribs& Attribs) noexcept(false);
+                                                   const ExecuteSuperResolutionAttribs& Attribs);
 
 class SuperResolutionBase : public ObjectBase<ISuperResolution>
 {

Graphics/SuperResolution/src/DSRProviderD3D12.cpp

@@ -170,10 +170,10 @@ SuperResolutionD3D12_DSR::~SuperResolutionD3D12_DSR() = default;
 void DILIGENT_CALL_TYPE SuperResolutionD3D12_DSR::Execute(const ExecuteSuperResolutionAttribs& Attribs)
 {
     ValidateTemporalExecuteSuperResolutionAttribs(m_Desc, Attribs);
-    VERIFY_SUPER_RESOLUTION(m_Desc.Name, Attribs.CameraNear > 0, "CameraNear must be greater than zero for temporal upscaling");
-    VERIFY_SUPER_RESOLUTION(m_Desc.Name, Attribs.CameraFar > 0, "CameraFar must be greater than zero for temporal upscaling.");
-    VERIFY_SUPER_RESOLUTION(m_Desc.Name, Attribs.CameraFovAngleVert > 0, "CameraFovAngleVert must be greater than zero for temporal upscaling.");
-    VERIFY_SUPER_RESOLUTION(m_Desc.Name, Attribs.TimeDeltaInSeconds >= 0, "TimeDeltaInSeconds must be non-negative.");
+    DEV_CHECK_SUPER_RESOLUTION(m_Desc.Name, Attribs.CameraNear > 0, "CameraNear must be greater than zero for temporal upscaling");
+    DEV_CHECK_SUPER_RESOLUTION(m_Desc.Name, Attribs.CameraFar > 0, "CameraFar must be greater than zero for temporal upscaling.");
+    DEV_CHECK_SUPER_RESOLUTION(m_Desc.Name, Attribs.CameraFovAngleVert > 0, "CameraFovAngleVert must be greater than zero for temporal upscaling.");
+    DEV_CHECK_SUPER_RESOLUTION(m_Desc.Name, Attribs.TimeDeltaInSeconds >= 0, "TimeDeltaInSeconds must be non-negative.");
 
     DeviceContextD3D12Impl* pCtx = ClassPtrCast<DeviceContextD3D12Impl>(Attribs.pContext);