Skip to content

Fix an issue that SwapChainDesc.DepthBufferFormat = TEX_FORMAT_R24G8_TYPELESS causing D3D12 invalid param error #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheMostDiligent merged 12 commits into from
Aug 3, 2025
Merged

Fix an issue that SwapChainDesc.DepthBufferFormat = TEX_FORMAT_R24G8_TYPELESS causing D3D12 invalid param error #691

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8fea35a
Add TEX_FORMAT_X24_TYPELESS_G8_UINT, TEX_FORMAT_X32_TYPELESS_G8X24_UI…
hzqst Jul 28, 2025
9e3dcad
Fix typo
hzqst Jul 28, 2025
98064f9
Add GL_ARB_stencil_texturing capability checking, and FormatInfo.Supp…
hzqst Jul 29, 2025
086a4c5
Add DEV_CHECK_GL_ERROR for glTexParameteri GL_DEPTH_STENCIL_TEXTURE_M…
hzqst Aug 1, 2025
f9e63f2
Fix formatting
hzqst Aug 1, 2025
cda2b7c
Replace auto with actual type
hzqst Aug 1, 2025
81e77a1
Add missing definition for GL_DEPTH_STENCIL_TEXTURE_MODE and GL_STENC…
hzqst Aug 1, 2025
d8e2b47
Fix formatting in GLStubsIOS.h
hzqst Aug 1, 2025
5a08125
Merge branch 'DiligentGraphics:master' into master
hzqst Aug 2, 2025
a018741
Fixed an issue that SwapChainDesc.DepthBufferFormat = TEX_FORMAT_R24G…
hzqst Aug 2, 2025
d43f82c
Fill ClearValue.Format with GetDefaultTextureViewFormat instead of De…
hzqst Aug 3, 2025
1b8eda1
Merge branch 'master' into d3d12_r24g8
TheMostDiligent Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Graphics/GraphicsEngineD3D12/src/SwapChainD3D12Impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ void SwapChainD3D12Impl::InitBuffersAndViews()
DepthBufferDesc.Usage = USAGE_DEFAULT;
DepthBufferDesc.BindFlags = BIND_DEPTH_STENCIL;

DepthBufferDesc.ClearValue.Format = DepthBufferDesc.Format;
DepthBufferDesc.ClearValue.Format = GetDefaultTextureViewFormat(DepthBufferDesc.Format, TEXTURE_VIEW_DEPTH_STENCIL, DepthBufferDesc.BindFlags);
DepthBufferDesc.ClearValue.DepthStencil.Depth = m_SwapChainDesc.DefaultDepthValue;
DepthBufferDesc.ClearValue.DepthStencil.Stencil = m_SwapChainDesc.DefaultStencilValue;
DepthBufferDesc.Name = "Main depth buffer";
Expand Down
Loading