Skip to content

Fix: no-enum-constexpr-conversion compilation error of DX12 backend with clang-cl #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheMostDiligent merged 2 commits into from
Aug 14, 2025
Merged

Fix: no-enum-constexpr-conversion compilation error of DX12 backend with clang-cl #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fed114
Fix: no-enum-constexpr-conversion compilation error of DX12 backend w…
JKot-Coder Aug 14, 2025
6615684
Merge branch 'master' into pr1
TheMostDiligent Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,6 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
INTERFACE
-Wno-microsoft-exception-spec
-Wno-tautological-constant-out-of-range-compare
-Wno-enum-constexpr-conversion
)
elseif (PLATFORM_APPLE)
# Allow unavailable API warnings not being errors as they tend to randomly
Expand Down
2 changes: 1 addition & 1 deletion Graphics/GraphicsEngineD3D12/src/RootParamsManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace Diligent
namespace
{

constexpr D3D12_DESCRIPTOR_RANGE_TYPE InvalidDescriptorRangeType = static_cast<D3D12_DESCRIPTOR_RANGE_TYPE>(-1);
const D3D12_DESCRIPTOR_RANGE_TYPE InvalidDescriptorRangeType = static_cast<D3D12_DESCRIPTOR_RANGE_TYPE>(-1);

#ifdef DILIGENT_DEBUG
void DbgValidateD3D12RootTable(const D3D12_ROOT_DESCRIPTOR_TABLE& d3d12Tbl)
Expand Down
Loading