Fix for globbing binary glTF files.#241
Merged
TheMostDiligent merged 1 commit intoOct 1, 2025
Merged
Conversation
triplejam
force-pushed
the
gltfbinariesglobbing
branch
2 times, most recently
from
September 24, 2025 10:34
ef9d61f to
7780fd8
Compare
Contributor
|
This change makes sense, though there are a couple of concerns:
|
triplejam
force-pushed
the
gltfbinariesglobbing
branch
from
September 25, 2025 12:04
7780fd8 to
8cd8cc2
Compare
Author
|
I'm not really sure the ideal way to deal with the first concern. There is no reason a user could not have a copy of the assets folder, decide to modify one of the file(s) in a pair. After which they could no longer be assumed equivalent. I've implemented a fix for the second. |
Author
|
Did you have any ideas boss for implementing the first how you want? It could just be by convention if the directories are named like they are in the Khronos GLTF assets folder. There's also more then two encodings the files can be in. |
Contributor
|
My current thinking is to add another command line argument to control the extensions: Default value will be |
triplejam
force-pushed
the
gltfbinariesglobbing
branch
from
September 30, 2025 15:42
8cd8cc2 to
fcdacec
Compare
TheMostDiligent
merged commit Oct 1, 2025
3c66d2d
into
DiligentGraphics:master
44 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary glTF files are not currently added to the list after choosing a directory via command line. Small patch to fix this.