add account menu in discover#2151
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds compact-screen account selection to Discover/Search by moving account switching into the search bar trailing icon while keeping chip-based selection on larger screens.
Changes:
- Adds optional
trailingIconsupport to the sharedSearchBar. - Adds compact account dropdown menus to Discover and Search screens.
- Restricts the existing account chip row to big-screen layouts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
app/src/main/java/dev/dimension/flare/ui/component/SearchBar.kt |
Exposes and forwards an optional trailing icon slot. |
app/src/main/java/dev/dimension/flare/ui/screen/home/DiscoverScreen.kt |
Adds compact account dropdown and big-screen-only account chips. |
app/src/main/java/dev/dimension/flare/ui/screen/home/SearchScreen.kt |
Adds compact account dropdown and big-screen-only account chips. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+74
to
+76
| trailingIcon = | ||
| state.searchState.selectedAccount?.let { account -> | ||
| if (!isBigScreen) { |
Comment on lines
+106
to
+115
| IconButton( | ||
| onClick = { | ||
| if (accounts.size > 1) { | ||
| showMenu = true | ||
| } | ||
| }, | ||
| ) { | ||
| AvatarComponent( | ||
| data = account.avatar, | ||
| ) |
Comment on lines
+80
to
+89
| IconButton( | ||
| onClick = { | ||
| if (accounts.size > 1) { | ||
| showMenu = true | ||
| } | ||
| }, | ||
| ) { | ||
| AvatarComponent( | ||
| data = account.avatar, | ||
| ) |
Comment on lines
+121
to
+125
| accounts.forEach { profile -> | ||
| DropdownMenuItem( | ||
| text = { | ||
| Text(profile.handle.canonical) | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.