fix tranquil pds#2268
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17a72a32a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| FanboxRecommendedCreators, | ||
| PixivPrivateFollowing, | ||
| PixivPrivateBookmarks, | ||
| BlueskyFixDelegationScopes, |
There was a problem hiding this comment.
Adding this enum value makes every exhaustive when over UiStrings cover it. I checked desktopApp/src/main/kotlin/dev/dimension/flare/ui/screen/home/EditTabDialog.kt:219-272, and that desktop mapping still ends at PixivPrivateBookmarks without an else, so the desktop target won't compile once it sees BlueskyFixDelegationScopes. Please add the desktop resource/mapping alongside this enum.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 120224f028
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| internal fun OAuthToken.missingFlareOAuthScopes(): List<String> { | ||
| val grantedScopes = scopes.mapTo(mutableSetOf()) { it.value } | ||
| return FLARE_BLUESKY_DELEGATION_SCOPES.filterNot(grantedScopes::contains) |
There was a problem hiding this comment.
When an OAuth server grants transition:generic transition:chat.bsky but omits atproto, this helper reports no missing scopes because it only checks the delegation subset. The ATProto OAuth profile says clients should reject token responses whose scope does not contain atproto (https://atproto.com/specs/oauth), so resumeOAuth can store a session that is not a valid atproto OAuth session and later PDS calls may fail; keep the repair list separate but validate against all required OAuth scopes.
Useful? React with 👍 / 👎.
1 participant
No description provided.