Version/1.7.0#2273
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Check presentation references when purging blocked users
When blocking/muting a user, deleteUserFromLocalCaches now loads DbPagingTimelineWithStatus rows that can include presentationReferences, but this predicate only checks the root status and semantic status.references. Reply-chain parents stored as presentation.inlineParents (notably Bluesky feed replies, which do not add a semantic Reply reference) can therefore remain cached and continue showing the blocked user's content until the timeline refreshes. Include presentationReferences in this check, or convert the row through the same presentation-aware user scan below.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| references = | ||
| listOfNotNull( | ||
| quote?.let { | ||
| UiTimelineV2.Post.Reference( | ||
| statusKey = it.statusKey, |
There was a problem hiding this comment.
When a Bluesky PostView is rendered directly (for example search results and bookmarks still call PostView.render(accountKey)), this keeps the embedded quote only as a Post.Reference and returns a bare Post. The new UI/cache path only displays and persists quote cards from TimelinePostItem.presentation.quotes; TimelinePagingMapper.toDb stores these reference-only quotes without the quoted status body, so the findQuote(...) result is dropped and quoted posts disappear in those timelines. Wrap these direct renders in a TimelinePostItem with PostPresentation(quotes = ...) as the feed path does.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bad4237114
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| composeStatus: ComposeStatus, | ||
| ): InitialText? { | ||
| if (post.quote.any() && composeStatus is ComposeStatus.Quote) { | ||
| if (quotes.any() && composeStatus is ComposeStatus.Quote) { |
There was a problem hiding this comment.
When a VVO post is loaded through PostHandler.post for compose, TimelinePostItem cache entries are converted back to a plain Post, so the quote body is often absent from presentation.quotes while the semantic Post.references still contains the ReferenceType.Quote. This condition then treats quoted/reposted VVO posts as unquoted and skips the //@... initial text for ComposeStatus.Quote; please fall back to the quote reference (or preserve the quote presentation) so quote compose from cached/direct post loads still initializes correctly.
Useful? React with 👍 / 👎.
1 participant
No description provided.