Skip to content

Commit 9b40266

Browse files
authored
Merge pull request #278 from DimensionDev/bugfix/ui
Bugfix/UI
2 parents 94d5d2a + 8df0024 commit 9b40266

5 files changed

Lines changed: 25 additions & 14 deletions

File tree

common/src/androidMain/kotlin/com/dimension/maskbook/common/ui/widget/NameImage.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,12 @@ package com.dimension.maskbook.common.ui.widget
2323
import androidx.compose.foundation.background
2424
import androidx.compose.foundation.layout.BoxWithConstraints
2525
import androidx.compose.foundation.shape.CircleShape
26-
import androidx.compose.material.LocalContentAlpha
2726
import androidx.compose.material.LocalTextStyle
2827
import androidx.compose.material.MaterialTheme
2928
import androidx.compose.material.Text
3029
import androidx.compose.runtime.Composable
3130
import androidx.compose.ui.Alignment
3231
import androidx.compose.ui.Modifier
33-
import androidx.compose.ui.draw.alpha
3432
import androidx.compose.ui.graphics.Color
3533
import androidx.compose.ui.text.TextStyle
3634
import androidx.compose.ui.unit.sp
@@ -41,11 +39,9 @@ fun NameImage(
4139
modifier: Modifier = Modifier,
4240
color: Color = MaterialTheme.colors.primary,
4341
style: TextStyle? = null,
44-
alpha: Float = LocalContentAlpha.current,
4542
) {
4643
BoxWithConstraints(
4744
modifier = modifier
48-
.alpha(alpha)
4945
.background(color, shape = CircleShape),
5046
contentAlignment = Alignment.Center,
5147
) {

common/src/androidMain/kotlin/com/dimension/maskbook/common/ui/widget/button/MaskListButton.kt

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,11 @@ package com.dimension.maskbook.common.ui.widget.button
2323
import androidx.annotation.DrawableRes
2424
import androidx.compose.foundation.Image
2525
import androidx.compose.foundation.layout.size
26+
import androidx.compose.material.Icon
2627
import androidx.compose.material.MaterialTheme
2728
import androidx.compose.runtime.Composable
2829
import androidx.compose.ui.Modifier
30+
import androidx.compose.ui.graphics.Color
2931
import androidx.compose.ui.res.painterResource
3032
import androidx.compose.ui.unit.dp
3133
import com.dimension.maskbook.common.ext.applyTextStyle
@@ -36,16 +38,26 @@ fun MaskListItemButton(
3638
onClick: () -> Unit,
3739
@DrawableRes icon: Int,
3840
trailing: @Composable (() -> Unit)? = null,
41+
tint: Color? = null,
3942
text: @Composable (() -> Unit),
4043
) {
4144
MaskButton(onClick = onClick) {
4245
MaskListItem(
4346
icon = {
44-
Image(
45-
painter = painterResource(icon),
46-
contentDescription = null,
47-
modifier = Modifier.size(32.dp),
48-
)
47+
if (tint != null) {
48+
Icon(
49+
painter = painterResource(icon),
50+
contentDescription = null,
51+
modifier = Modifier.size(32.dp),
52+
tint = tint,
53+
)
54+
} else {
55+
Image(
56+
painter = painterResource(icon),
57+
contentDescription = null,
58+
modifier = Modifier.size(32.dp),
59+
)
60+
}
4961
},
5062
text = text,
5163
trailing = applyTextStyle(MaterialTheme.typography.h5, trailing),

persona/src/androidMain/kotlin/com/dimension/maskbook/persona/ui/scenes/PersonaMenuScene.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ package com.dimension.maskbook.persona.ui.scenes
2222

2323
import android.net.Uri
2424
import android.util.Base64
25-
import androidx.compose.foundation.Image
2625
import androidx.compose.foundation.layout.Column
2726
import androidx.compose.foundation.layout.Row
2827
import androidx.compose.foundation.layout.Spacer
@@ -223,10 +222,11 @@ private fun MenuItem(
223222
modifier = Modifier.padding(16.dp),
224223
verticalAlignment = Alignment.CenterVertically,
225224
) {
226-
Image(
225+
Icon(
227226
painterResource(id = icon),
228227
contentDescription = null,
229-
modifier = Modifier.size(32.dp)
228+
modifier = Modifier.size(32.dp),
229+
tint = MaterialTheme.colors.primary,
230230
)
231231
Spacer(modifier = Modifier.width(8.dp))
232232
Text(text = title, style = MaterialTheme.typography.h5, modifier = Modifier.weight(1f))

wallet/src/androidMain/kotlin/com/dimension/maskbook/wallet/ui/scenes/wallets/management/WalletManagementModal.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import androidx.compose.foundation.layout.Arrangement
2424
import androidx.compose.foundation.layout.Column
2525
import androidx.compose.foundation.layout.fillMaxWidth
2626
import androidx.compose.material.ExperimentalMaterialApi
27+
import androidx.compose.material.MaterialTheme
2728
import androidx.compose.material.Text
2829
import androidx.compose.runtime.Composable
2930
import androidx.compose.ui.Modifier
@@ -65,19 +66,22 @@ fun WalletManagementModal(
6566
},
6667
trailing = {
6768
Text(text = walletData?.name.orEmpty())
68-
}
69+
},
70+
tint = MaterialTheme.colors.primary,
6971
)
7072
if (walletData != null && !walletData.fromWalletConnect) {
7173
MaskListItemButton(
7274
onClick = onBackup,
7375
icon = R.drawable.ic_back_up,
76+
tint = MaterialTheme.colors.primary,
7477
) {
7578
Text(text = stringResource(R.string.scene_personas_action_backup))
7679
}
7780
}
7881
MaskListItemButton(
7982
onClick = onTransactionHistory,
8083
icon = R.drawable.ic_transaction_history,
84+
tint = MaterialTheme.colors.primary,
8185
) {
8286
Text(text = stringResource(R.string.scene_wallet_detail_wallet_items_history))
8387
}

wallet/src/androidMain/kotlin/com/dimension/maskbook/wallet/ui/scenes/wallets/management/WalletSwitchModal.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ fun WalletSwitchSceneModal(
190190
NameImage(
191191
name = wallet.name,
192192
modifier = Modifier.size(32.dp),
193-
alpha = 1f,
194193
color = wallet.name.walletColor
195194
)
196195
},

0 commit comments

Comments
 (0)