refactor(backend): extract shared cores and align mobile RPC parity

Author: Dimillian

docs/mobile-ios-cloudflare-blueprint.md

@@ -18,7 +18,10 @@ This document is the canonical implementation plan for shipping CodexMonitor on
   - `app-server-event`
   - `terminal-output`
   - `terminal-exit`
-- Daemon RPC surface does not match full local Tauri command surface yet (major parity gap).
+- Mobile UI scope is the existing app layout in mobile form-factor (no separate mobile-only feature surface).
+- Shared-core parity refactor is in place for prompts, local usage, codex utility helpers, git/github UI helpers, and workspace actions.
+- Daemon RPC parity for the current mobile scope is complete.
+- `terminal_*` and `dictation_*` command parity are intentionally out of scope for this mobile phase.
 
 ## Target Architecture
 
@@ -214,32 +217,37 @@ Behavior:
 - Outbound WS to Worker.
 - Translate bridge envelopes <-> existing RPC handler + event bus.
 
-## 6) Command parity completion (blocking)
+## 6) Command parity scope (mobile phase)
 
-Remote mode must support the full local command surface used by UI.
+Remote mode must support all commands exercised by the current mobile UI surface.
 
-Implement missing daemon methods and/or remote routing for at least:
+Implemented in shared core + daemon/app adapters:
 
-- Git commands:
+- Git + GitHub UI commands:
   - `list_git_roots`, `get_git_status`, `get_git_diffs`, `get_git_log`, `get_git_commit_diff`, `get_git_remote`
   - `list_git_branches`, `checkout_git_branch`, `create_git_branch`
   - `stage_git_file`, `stage_git_all`, `unstage_git_file`
   - `revert_git_file`, `revert_git_all`
   - `commit_git`, `push_git`, `pull_git`, `fetch_git`, `sync_git`
-  - GitHub API commands for issues/PRs/comments/diff
-- Terminal commands:
-  - `terminal_open`, `terminal_write`, `terminal_resize`, `terminal_close`
+  - GitHub issues/PRs/comments/diff commands
 - Prompts commands:
   - `prompts_list`, `prompts_create`, `prompts_update`, `prompts_delete`, `prompts_move`, `prompts_workspace_dir`, `prompts_global_dir`
-- Dictation commands:
-  - `dictation_model_status`, `dictation_download_model`, `dictation_cancel_download`, `dictation_remove_model`, `dictation_start`, `dictation_request_permission`, `dictation_stop`, `dictation_cancel`
 - Workspace/app extras:
   - `add_clone`, `apply_worktree_changes`, `open_workspace_in`, `get_open_app_icon`
 - Utility commands:
   - `codex_doctor`, `get_commit_message_prompt`, `generate_commit_message`, `generate_run_metadata`, `local_usage_snapshot`, `send_notification_fallback`, `is_macos_debug_build`, `menu_set_accelerators`
 
-Add CI guard:
-- Script that parses `generate_handler![]` and daemon RPC dispatch and fails on mismatch.
+Out of scope for this mobile phase:
+
+- Terminal commands:
+  - `terminal_open`, `terminal_write`, `terminal_resize`, `terminal_close`
+- Dictation commands:
+  - `dictation_model_status`, `dictation_download_model`, `dictation_cancel_download`, `dictation_remove_model`, `dictation_start`, `dictation_request_permission`, `dictation_stop`, `dictation_cancel`
+
+Validation policy:
+
+- No CI parity guard is required for this phase.
+- Validate parity locally before merge (build/tests + remote-mode smoke checks).
 
 ## Frontend Plan
 
@@ -423,17 +431,18 @@ cargo test
 3. Connect workspace.
 4. Start thread, send messages, interrupt turn.
 5. Git diff panel operations.
-6. Terminal open/write/resize/close.
-7. Prompts CRUD.
-8. Background iOS app, resume, ensure state resync.
-9. macOS runner restart, iOS auto-reconnect.
+6. Prompts CRUD.
+7. Verify terminal UI is not exposed in mobile mode.
+8. Verify dictation UI is not exposed in mobile mode.
+9. Background iOS app, resume, ensure state resync.
+10. macOS runner restart, iOS auto-reconnect.
 
 ## Implementation Milestones
 
 1. Milestone A: iOS compile baseline + mobile-safe stubs.
 2. Milestone B: Cloudflare Worker + DO bridge deployed + tested with mock clients.
 3. Milestone C: remote_backend transport refactor + runner bridge mode.
-4. Milestone D: daemon parity closure + CI parity guard.
+4. Milestone D: daemon parity closure for mobile scope (excluding terminal/dictation).
 5. Milestone E: settings UX/service manager + pairing UX.
 6. Milestone F: full E2E validation and TestFlight beta.
 
@@ -452,7 +461,7 @@ cargo test
 2. Implement Milestone A first and ensure local iOS dev build works.
 3. Implement Cloudflare bridge in isolation (mock runner/client).
 4. Refactor `remote_backend` to transport abstraction.
-5. Complete daemon parity and add parity CI guard.
+5. Complete daemon parity for mobile scope and validate locally.
 6. Build settings UX and runner service controls.
 7. Validate full manual checklist on simulator and physical device.
 8. Ship behind feature flag, then remove flag after beta validation.

memory/decisions.md

@@ -141,3 +141,52 @@ Type: preference
 Event: User explicitly requested to ignore PR #31 and CloudKit for mobile architecture planning.
 Action: Canonical mobile plan now targets Cloudflare bridge only, with no dependency on CloudKit or PR #31 implementation details.
 Rule: Do not propose CloudKit/PR31-based mobile backend patterns unless user re-requests them.
+
+## 2026-02-07 15:11
+Context: Mobile UI scope confirmation
+Type: preference
+Event: User confirmed iOS should reuse the current app layout's mobile variant instead of introducing a separate mobile-only UI surface.
+Action: Treat mobile work as backend/connectivity enablement for existing mobile-responsive UI flows.
+Rule: For iOS rollout, prioritize backend/transport parity for existing UI flows before designing net-new mobile-specific screens.
+
+## 2026-02-07 15:26
+Context: App/daemon parity refactor quality bar
+Type: preference
+Event: User requested parity work avoid repeated logical code between app and daemon, with shared implementations as the default.
+Action: Current in-progress daemon parity changes must be completed by extracting/using shared core helpers instead of duplicating logic in daemon-specific functions.
+Rule: For app/daemon parity, keep domain logic in shared modules and restrict app/daemon code to thin adapters.
+
+## 2026-02-07 15:42
+Context: Daemon parity implementation scope for mobile wiring
+Type: preference
+Event: User explicitly excluded terminal and dictation from current mobile/remote parity work.
+Action: Implemented daemon RPC parity for non-terminal/non-dictation methods and validated parity gap now contains only `terminal_*` and `dictation_*` commands.
+Rule: For current mobile remote-mode rollout, treat terminal and dictation RPC parity as out of scope unless the user re-enables them.
+
+## 2026-02-07 16:58
+Context: App/daemon parity dedup for mobile remote-mode backend
+Type: decision
+Event: Refactored duplicated prompt/local-usage/codex-utility/git logic into shared core modules and switched app/daemon code to adapter-only wrappers.
+Action: Added `shared/prompts_core.rs`, `shared/local_usage_core.rs`, `shared/codex_aux_core.rs`, and `shared/git_ui_core.rs`; rewired `prompts.rs`, `local_usage.rs`, `git/mod.rs`, `codex/mod.rs`, and daemon method handlers to call shared functions.
+Rule: Keep user-facing git/prompt/local-usage/codex utility behavior in shared cores and keep app/daemon files limited to transport/wiring responsibilities.
+
+## 2026-02-07 17:22
+Context: Remaining workspace-action parity dedup
+Type: decision
+Event: `add_clone`, `apply_worktree_changes`, `open_workspace_in`, and `get_open_app_icon` still duplicated between app and daemon after first parity refactor pass.
+Action: Moved those behaviors into `shared/workspaces_core.rs` (`add_clone_core`, `apply_worktree_changes_core`, `open_workspace_in_core`, `get_open_app_icon_core`) and rewired both app (`workspaces/commands.rs`) and daemon (`codex_monitor_daemon.rs`) to thin adapters.
+Rule: Keep workspace action behavior shared-first; app and daemon should only pass environment dependencies and transport payloads.
+
+## 2026-02-07 17:26
+Context: Backend test-target dead code warnings
+Type: decision
+Event: `cargo test` warnings came from a truly unused test hook and a test helper compiled in targets that do not reference it.
+Action: Removed unused `set_window_appearance_override` from `window.rs`; added `#[allow(dead_code)]` to `workspaces/settings.rs::sort_workspaces` (test-only helper used in lib tests but not daemon test target).
+Rule: Remove genuinely unused test hooks; for cross-target test helpers, use narrow `#[allow(dead_code)]` instead of broad warning suppression.
+
+## 2026-02-07 17:32
+Context: Mobile parity verification policy
+Type: preference
+Event: User explicitly requested no CI parity guard for this phase and to rely on local validation.
+Action: Updated mobile Cloudflare blueprint to remove CI parity guard requirements and require local parity validation only.
+Rule: For current mobile/remote scope, do not add CI parity guardrails unless user requests them again.

memory/mistakes.md

@@ -21,3 +21,13 @@ Rule: Avoid redefining primitive-owned positioning styles in migrated feature sh
 Root cause: `.settings-window { position: relative; }` overrode `.ds-modal-card` absolute centering because `settings.css` loads after `ds-modal.css`.
 Fix applied: Removed `position` and `z-index` from `.settings-window` so DS card positioning controls centering.
 Prevention rule: When migrating existing shell classes onto DS primitives, avoid redeclaring layout-positioning properties (`position/top/left/transform`) already owned by the primitive.
+
+## 2026-02-07 16:58
+Context: Codex utility dedup refactor (`src-tauri/src/codex/mod.rs`)
+Type: mistake
+Event: A bulk file rewrite command truncated `codex/mod.rs` during refactor, temporarily dropping unrelated command handlers.
+Action: Restored file from `HEAD` immediately and reapplied refactor using targeted replacements/patches only.
+Rule: For large Rust modules, avoid full-file/head-tail rewrites unless line boundaries are verified; prefer function-scoped `apply_patch` edits.
+Root cause: Used brittle line-count/head-tail rewrite workflow while file contents were changing.
+Fix applied: Recovered from git snapshot and switched to explicit function-level patching.
+Prevention rule: Use patch hunks anchored on function signatures for high-churn files and verify file length/function inventory after each structural edit.

memory/todo.md

@@ -8,3 +8,8 @@
 - [x] Complete phase-2 design-system migration cleanup for targeted families (modals, toasts, panel shells, diff theme defaults).
 - [x] Add lint/codemod automation for DS primitive adoption (`modal-shell`, `panel-shell`, `toast-shell`) as defined in `docs/design-system-migration-plan.md`.
 - [x] Run manual visual parity QA checklist for migrated modal/toast/panel/diff families and delete remaining unreferenced legacy selectors.
+- [x] 2026-02-07: Replace daemon `local_usage_snapshot` temporary zeroed snapshot implementation with shared real session-log scanner parity.
+- [x] 2026-02-07: Extract newly mirrored daemon git/github/prompts/codex utility logic into shared core modules to eliminate remaining app/daemon duplication.
+- [x] 2026-02-07: Replace daemon `local_usage_snapshot` temporary implementation by sharing real local usage scanner logic in `shared/local_usage_core.rs`.
+- [x] 2026-02-07: Eliminate app/daemon duplication for git/github/prompt/codex utility behavior via shared cores (`git_ui_core`, `prompts_core`, `codex_aux_core`).
+- [x] 2026-02-07: Move remaining duplicated workspace-action logic (`add_clone`, `apply_worktree_changes`, `open_workspace_in`, `get_open_app_icon`) into shared core helpers.