fix: keep workspace routes out of file links

Author: Reekin

src/features/messages/components/Markdown.test.tsx

@@ -313,6 +313,78 @@ describe("Markdown file-like href behavior", () => {
     expect(onOpenFileLink).not.toHaveBeenCalled();
   });
 
+  it("keeps workspace settings #L anchors as local routes", () => {
+    const onOpenFileLink = vi.fn();
+    render(
+      <Markdown
+        value="See [settings](/workspace/settings#L12)"
+        className="markdown"
+        workspacePath="/Users/sotiriskaniras/Documents/Development/Forks/CodexMonitor"
+        onOpenFileLink={onOpenFileLink}
+      />,
+    );
+
+    const link = screen.getByText("settings").closest("a");
+    expect(link?.getAttribute("href")).toBe("/workspace/settings#L12");
+
+    const clickEvent = createEvent.click(link as Element, {
+      bubbles: true,
+      cancelable: true,
+    });
+    fireEvent(link as Element, clickEvent);
+    expect(clickEvent.defaultPrevented).toBe(true);
+    expect(onOpenFileLink).not.toHaveBeenCalled();
+  });
+
+  it("keeps workspace reviews #L anchors as local routes", () => {
+    const onOpenFileLink = vi.fn();
+    render(
+      <Markdown
+        value="See [reviews](/workspace/reviews#L9)"
+        className="markdown"
+        workspacePath="/Users/sotiriskaniras/Documents/Development/Forks/CodexMonitor"
+        onOpenFileLink={onOpenFileLink}
+      />,
+    );
+
+    const link = screen.getByText("reviews").closest("a");
+    expect(link?.getAttribute("href")).toBe("/workspace/reviews#L9");
+
+    const clickEvent = createEvent.click(link as Element, {
+      bubbles: true,
+      cancelable: true,
+    });
+    fireEvent(link as Element, clickEvent);
+    expect(clickEvent.defaultPrevented).toBe(true);
+    expect(onOpenFileLink).not.toHaveBeenCalled();
+  });
+
+  it("does not linkify workspace settings #L anchors in plain text", () => {
+    const { container } = render(
+      <Markdown
+        value="See /workspace/settings#L12 for app settings."
+        className="markdown"
+        workspacePath="/Users/sotiriskaniras/Documents/Development/Forks/CodexMonitor"
+      />,
+    );
+
+    expect(container.querySelector(".message-file-link")).toBeNull();
+    expect(container.textContent).toContain("/workspace/settings#L12");
+  });
+
+  it("does not turn workspace review #L anchors in inline code into file links", () => {
+    const { container } = render(
+      <Markdown
+        value="Use `/workspace/reviews#L9` to reference the reviews route."
+        className="markdown"
+        workspacePath="/Users/sotiriskaniras/Documents/Development/Forks/CodexMonitor"
+      />,
+    );
+
+    expect(container.querySelector(".message-file-link")).toBeNull();
+    expect(container.querySelector("code")?.textContent).toBe("/workspace/reviews#L9");
+  });
+
   it("does not turn natural-language slash phrases into file links", () => {
     const { container } = render(
       <Markdown

src/features/messages/components/Markdown.tsx

@@ -4,6 +4,7 @@ import remarkGfm from "remark-gfm";
 import { openUrl } from "@tauri-apps/plugin-opener";
 import {
   fromFileUrl,
+  isKnownLocalWorkspaceRoutePath as isKnownLocalWorkspaceRouteFilePath,
   normalizeFileLinkPath,
   parseFileLocation,
 } from "../../../utils/fileLinks";
@@ -349,6 +350,12 @@ function isLikelyFileHref(
   }
   if (pathOnly.startsWith("/")) {
     if (parsedLocation.line !== null) {
+      const normalizedPath = pathOnly.replace(/\\/g, "/");
+      if (
+        WORKSPACE_ROUTE_PREFIXES.some((prefix) => normalizedPath.startsWith(prefix))
+      ) {
+        return isLikelyMountedWorkspaceFilePath(normalizedPath, workspacePath);
+      }
       return true;
     }
     if (hasLikelyFileName(pathOnly)) {
@@ -664,6 +671,9 @@ export function Markdown({
     if (!normalizedPath) {
       return null;
     }
+    if (isKnownLocalWorkspaceRouteFilePath(normalizedPath)) {
+      return null;
+    }
     if (!isLinkableFilePath(normalizedPath)) {
       return null;
     }

src/utils/fileLinks.ts

@@ -83,6 +83,25 @@ export function normalizeFileLinkPath(rawPath: string) {
   return formatFileLocation(parsed.path, parsed.line, parsed.column);
 }
 
+export function isKnownLocalWorkspaceRoutePath(rawPath: string) {
+  const normalizedPath = parseFileLocation(rawPath).path.trim().replace(/\\/g, "/");
+  if (normalizedPath.startsWith("/workspace/")) {
+    const routeSegment = normalizedPath
+      .slice("/workspace/".length)
+      .split("/")
+      .filter(Boolean)[0];
+    return routeSegment === "reviews" || routeSegment === "settings";
+  }
+  if (normalizedPath.startsWith("/workspaces/")) {
+    const routeSegment = normalizedPath
+      .slice("/workspaces/".length)
+      .split("/")
+      .filter(Boolean)[1];
+    return routeSegment === "reviews" || routeSegment === "settings";
+  }
+  return false;
+}
+
 type FileUrlParts = {
   host: string;
   pathname: string;

src/utils/remarkFileLinks.ts

@@ -1,4 +1,8 @@
-import { FILE_LINK_SUFFIX_SOURCE, normalizeFileLinkPath } from "./fileLinks";
+import {
+  FILE_LINK_SUFFIX_SOURCE,
+  isKnownLocalWorkspaceRoutePath,
+  normalizeFileLinkPath,
+} from "./fileLinks";
 
 const FILE_LINK_PROTOCOL = "codex-file:";
 const POSIX_OR_RELATIVE_FILE_PATH_PATTERN =
@@ -93,6 +97,11 @@ function linkifyText(value: string) {
     const { path, trailing } = splitTrailingPunctuation(raw);
     if (path && isPathCandidate(path, leadingText, previousChar)) {
       const normalizedPath = normalizeFileLinkPath(path);
+      if (isKnownLocalWorkspaceRoutePath(normalizedPath)) {
+        nodes.push({ type: "text", value: raw });
+        lastIndex = matchIndex + raw.length;
+        continue;
+      }
       nodes.push({
         type: "link",
         url: toFileLink(normalizedPath),
@@ -154,6 +163,9 @@ export function isLinkableFilePath(value: string) {
   if (!trimmed) {
     return false;
   }
+  if (isKnownLocalWorkspaceRoutePath(trimmed)) {
+    return false;
+  }
   if (!FILE_PATH_MATCH.test(trimmed)) {
     return false;
   }