fix: narrow mounted route guards for file links

Author: Reekin

src/features/messages/components/Markdown.test.tsx

@@ -161,19 +161,19 @@ describe("Markdown file-like href behavior", () => {
     expect(onOpenFileLink).toHaveBeenCalledWith("/workspace/dist/assets");
   });
 
-  it("keeps generic workspace routes as normal markdown links", () => {
+  it("keeps exact workspace routes as normal markdown links", () => {
     const onOpenFileLink = vi.fn();
     render(
       <Markdown
-        value="See [overview](/workspace/reviews/overview)"
+        value="See [reviews](/workspace/reviews)"
         className="markdown"
         workspacePath="/Users/sotiriskaniras/Documents/Development/Forks/CodexMonitor"
         onOpenFileLink={onOpenFileLink}
       />,
     );
 
-    const link = screen.getByText("overview").closest("a");
-    expect(link?.getAttribute("href")).toBe("/workspace/reviews/overview");
+    const link = screen.getByText("reviews").closest("a");
+    expect(link?.getAttribute("href")).toBe("/workspace/reviews");
 
     const clickEvent = createEvent.click(link as Element, {
       bubbles: true,
@@ -588,4 +588,48 @@ describe("Markdown file-like href behavior", () => {
     expect(clickEvent.defaultPrevented).toBe(true);
     expect(onOpenFileLink).toHaveBeenCalledWith("/tmp/report#L12.md");
   });
+
+  it("still opens mounted file links when the workspace basename is settings", () => {
+    const onOpenFileLink = vi.fn();
+    render(
+      <Markdown
+        value="See [app](/workspace/settings/src/App.tsx)"
+        className="markdown"
+        onOpenFileLink={onOpenFileLink}
+      />,
+    );
+
+    const link = screen.getByText("app").closest("a");
+    expect(link?.getAttribute("href")).toBe("/workspace/settings/src/App.tsx");
+
+    const clickEvent = createEvent.click(link as Element, {
+      bubbles: true,
+      cancelable: true,
+    });
+    fireEvent(link as Element, clickEvent);
+    expect(clickEvent.defaultPrevented).toBe(true);
+    expect(onOpenFileLink).toHaveBeenCalledWith("/workspace/settings/src/App.tsx");
+  });
+
+  it("linkifies mounted file paths when the nested workspace basename is reviews", () => {
+    const onOpenFileLink = vi.fn();
+    const { container } = render(
+      <Markdown
+        value="See /workspaces/team/reviews/src/App.tsx for details."
+        className="markdown"
+        onOpenFileLink={onOpenFileLink}
+      />,
+    );
+
+    const link = container.querySelector('a[href^="codex-file:"]');
+    expect(link).not.toBeNull();
+
+    const clickEvent = createEvent.click(link as Element, {
+      bubbles: true,
+      cancelable: true,
+    });
+    fireEvent(link as Element, clickEvent);
+    expect(clickEvent.defaultPrevented).toBe(true);
+    expect(onOpenFileLink).toHaveBeenCalledWith("/workspaces/team/reviews/src/App.tsx");
+  });
 });

src/features/messages/components/Markdown.tsx

@@ -274,9 +274,13 @@ function isKnownLocalWorkspaceRoutePath(path: string) {
 
   const routeSegment =
     mountedPath.prefix === "/workspace/"
-      ? mountedPath.segments[0]
-      : mountedPath.segments[1];
-  return Boolean(routeSegment) && LOCAL_WORKSPACE_ROUTE_SEGMENTS.has(routeSegment);
+      ? mountedPath.segments.length === 1
+        ? mountedPath.segments[0]
+        : null
+      : mountedPath.segments.length === 2
+        ? mountedPath.segments[1]
+        : null;
+  return routeSegment !== null && LOCAL_WORKSPACE_ROUTE_SEGMENTS.has(routeSegment);
 }
 
 function isLikelyMountedWorkspaceFilePath(

src/utils/fileLinks.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { fromFileUrl } from "./fileLinks";
+import { fromFileUrl, isKnownLocalWorkspaceRoutePath } from "./fileLinks";
 
 function withThrowingUrlConstructor(run: () => void) {
   const originalUrl = globalThis.URL;
@@ -71,3 +71,23 @@ describe("fromFileUrl", () => {
     });
   });
 });
+
+describe("isKnownLocalWorkspaceRoutePath", () => {
+  it("matches only exact mounted settings and reviews routes", () => {
+    expect(isKnownLocalWorkspaceRoutePath("/workspace/settings")).toBe(true);
+    expect(isKnownLocalWorkspaceRoutePath("/workspace/reviews")).toBe(true);
+    expect(isKnownLocalWorkspaceRoutePath("/workspaces/team/settings")).toBe(true);
+    expect(isKnownLocalWorkspaceRoutePath("/workspaces/team/reviews")).toBe(true);
+  });
+
+  it("does not treat deeper mounted paths as reserved routes", () => {
+    expect(isKnownLocalWorkspaceRoutePath("/workspace/settings/src/App.tsx")).toBe(false);
+    expect(isKnownLocalWorkspaceRoutePath("/workspace/reviews/src/App.tsx")).toBe(false);
+    expect(isKnownLocalWorkspaceRoutePath("/workspaces/team/settings/src/App.tsx")).toBe(
+      false,
+    );
+    expect(isKnownLocalWorkspaceRoutePath("/workspaces/team/reviews/src/App.tsx")).toBe(
+      false,
+    );
+  });
+});

src/utils/fileLinks.ts

@@ -179,18 +179,22 @@ export function normalizeFileLinkPath(rawPath: string) {
 export function isKnownLocalWorkspaceRoutePath(rawPath: string) {
   const normalizedPath = parseFileLocation(rawPath).path.trim().replace(/\\/g, "/");
   if (normalizedPath.startsWith("/workspace/")) {
-    const routeSegment = normalizedPath
+    const mountedSegments = normalizedPath
       .slice("/workspace/".length)
       .split("/")
-      .filter(Boolean)[0];
-    return routeSegment === "reviews" || routeSegment === "settings";
+      .filter(Boolean);
+    return mountedSegments.length === 1
+      ? mountedSegments[0] === "reviews" || mountedSegments[0] === "settings"
+      : false;
   }
   if (normalizedPath.startsWith("/workspaces/")) {
-    const routeSegment = normalizedPath
+    const mountedSegments = normalizedPath
       .slice("/workspaces/".length)
       .split("/")
-      .filter(Boolean)[1];
-    return routeSegment === "reviews" || routeSegment === "settings";
+      .filter(Boolean);
+    return mountedSegments.length === 2
+      ? mountedSegments[1] === "reviews" || mountedSegments[1] === "settings"
+      : false;
   }
   return false;
 }