Apply Sourcery suggestions and fix typos

Author: DimitriPapadopoulos

src/zarr/abc/metadata.py

@@ -28,8 +28,6 @@ def to_dict(self) -> dict[str, JSON]:
             value = getattr(self, key)
             if isinstance(value, Metadata):
                 out_dict[field.name] = getattr(self, field.name).to_dict()
-            elif isinstance(value, str):
-                out_dict[key] = value
             elif isinstance(value, Sequence):
                 out_dict[key] = tuple(v.to_dict() if isinstance(v, Metadata) else v for v in value)
             else:

src/zarr/codecs/sharding.py

@@ -115,7 +115,7 @@ class _ShardIndex(NamedTuple):
 
     @property
     def chunks_per_shard(self) -> ChunkCoords:
-        result = tuple(self.offsets_and_lengths.shape[0:-1])
+        result = tuple(self.offsets_and_lengths.shape[:-1])
         # The cast is required until https://github.com/numpy/numpy/pull/27211 is merged
         return cast("ChunkCoords", result)
 
@@ -421,8 +421,8 @@ def validate(
             )
         if not isinstance(chunk_grid, RegularChunkGrid):
             raise TypeError("Sharding is only compatible with regular chunk grids.")
-        if not all(
-            s % c == 0
+        if any(
+            s % c != 0
             for s, c in zip(
                 chunk_grid.chunk_shape,
                 self.chunk_shape,

src/zarr/core/array.py

@@ -660,7 +660,7 @@ async def _create(
                 overwrite=overwrite,
             )
         else:
-            raise ValueError(f"Insupported zarr_format. Got: {zarr_format}")
+            raise ValueError(f"Unsupported zarr_format. Got: {zarr_format}")
 
         if data is not None:
             # insert user-provided data

src/zarr/core/buffer/core.py

@@ -115,7 +115,7 @@ def check_item_key_is_1d_contiguous(key: Any) -> None:
         raise TypeError(
             f"Item key has incorrect type (expected slice, got {key.__class__.__name__})"
         )
-    if not (key.step is None or key.step == 1):
+    if key.step is not None and key.step != 1:
         raise ValueError("slice must be contiguous")
 
 

src/zarr/core/common.py

@@ -152,7 +152,7 @@ def parse_shapelike(data: int | Iterable[int]) -> tuple[int, ...]:
     if not all(isinstance(v, int) for v in data_tuple):
         msg = f"Expected an iterable of integers. Got {data} instead."
         raise TypeError(msg)
-    if not all(v > -1 for v in data_tuple):
+    if any(v < 0 for v in data_tuple):
         msg = f"Expected all values to be non-negative. Got {data} instead."
         raise ValueError(msg)
     return data_tuple

src/zarr/core/indexing.py

@@ -436,7 +436,7 @@ def replace_ellipsis(selection: Any, shape: ChunkCoords) -> SelectionNormalized:
     selection = ensure_tuple(selection)
 
     # count number of ellipsis present
-    n_ellipsis = sum(1 for i in selection if i is Ellipsis)
+    n_ellipsis = selection.count(Ellipsis)
 
     if n_ellipsis > 1:
         # more than 1 is an error

src/zarr/core/metadata/v2.py

@@ -266,11 +266,11 @@ def parse_filters(data: object) -> tuple[numcodecs.abc.Codec, ...] | None:
     """
     Parse a potential tuple of filters
     """
-    out: list[numcodecs.abc.Codec] = []
 
     if data is None:
         return data
     if isinstance(data, Iterable):
+        out: list[numcodecs.abc.Codec] = []
         for idx, val in enumerate(data):
             if isinstance(val, numcodecs.abc.Codec):
                 out.append(val)