Add macOS Build Support#30
Conversation
|
DinosaurPlanetRecompiled.zip |
Francessco121
left a comment
Francessco121
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
I'm not totally sure how to proceed with this truthfully, as I don't have the means to maintain any of this code going forward (I do not own a mac). It's very likely that future updates will break macOS support and require someone else to step in.
That said, if this were to get merged and released, there's a couple important things that need to be sorted out first:
- Debug UI support.
- A GitHub Actions job to make a release build.
There was a problem hiding this comment.
The new additions aren't really formatted like the rest of the document but that's something I can address later, not a big deal.
| case RT64::UserConfiguration::GraphicsAPI::Metal: { | ||
| // Metal not supported for debug UI | ||
| #ifdef __APPLE__ | ||
| ImGui_ImplMetal_Init(nullptr); |
There was a problem hiding this comment.
It looks like (and I could be wrong) ImGui_ImplMetal_NewFrame cannot take a nullptr. Have you had a chance to test this?
There was a problem hiding this comment.
Hey there! Sorry about that, you're right - I did test it and sadly it still needs work. Haven't had the chance to continue working on it though. I'm going to see if I can get some work in tonight to get it going!
|
Thanks for looking into ImGui and the CI. I'm not in a good spot to properly review this right now but I'll be considering merging this and shipping a mac build for the next recomp release. |
|
any chance we can get an update on this? |
3 participants
This should help with #25 :)