cut. cop. paste. password type#375
Closed
niminypiminy wants to merge 68 commits intoDioxusLabs:mainfrom
Closed
Conversation
This fixes the open bug for segmentation core dump. surface should now drop properly on linux/wayland
added #[cfg(target_os = "linux")] so it only runs on linux
wayland data control for linux. (needed for cut, copy, paste)
Clippy & formatting fix
element.rs: added shadow_text and is_password flag. construct.rs: added type password & dots. keyboard.rs: swap keys for dots form.rs: hitting submit should extract plaint text, not dots. tested on linux. did not test on other OS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous pull was fine, but to satisfy your concerns over the "hacky" comment I left in the code.
That code was just aborting early to solve the reported bug on linux. #355
However, if someone has a custom runtime, like me, then aborting will cause breaking changes.
That may be unfavorable to some folks.
I simply removed it. Problem solved.
The other code should be fine. Password- type is robust. Cut, copy, paste works, although it could be extended.
In regards to clippy and fmt complaints, you may edit/format as needed to achieve your preferred style.
This was done for my project. If it helps, merge it. If not, reject. No worries.