shrink diff

Author: ealmloff

.github/workflows/main.yml

@@ -20,13 +20,13 @@ jobs:
     with:
       all-features: false
       no-default-features: true
-      features: dioxus-code/all-languages dioxus-code-editor/web dioxus-code-docsite/web dioxus-code-live-input/web
+      features: dioxus-code/all-languages dioxus-code-docsite/web dioxus-code-live-input/web
 
   test:
     uses: dioxuslabs/dioxus-ci/.github/workflows/test.yml@v0.1.0
     with:
       no-default-features: true
-      features: dioxus-code/all-languages dioxus-code-editor/web dioxus-code-docsite/web dioxus-code-live-input/web
+      features: dioxus-code/all-languages dioxus-code-docsite/web dioxus-code-live-input/web
 
   fmt:
     uses: dioxuslabs/dioxus-ci/.github/workflows/fmt.yml@v0.1.0
@@ -36,11 +36,11 @@ jobs:
     with:
       all-features: false
       no-default-features: true
-      features: dioxus-code/all-languages dioxus-code-editor/web dioxus-code-docsite/web dioxus-code-live-input/web
+      features: dioxus-code/all-languages dioxus-code-docsite/web dioxus-code-live-input/web
 
   clippy:
     uses: dioxuslabs/dioxus-ci/.github/workflows/clippy.yml@v0.1.0
     with:
       all-features: false
       no-default-features: true
-      features: dioxus-code/all-languages dioxus-code-editor/web dioxus-code-docsite/web dioxus-code-live-input/web
+      features: dioxus-code/all-languages dioxus-code-docsite/web dioxus-code-live-input/web

.github/workflows/nightly.yml

@@ -19,22 +19,22 @@ jobs:
       toolchain: nightly
       all-features: false
       no-default-features: true
-      features: dioxus-code/all-languages dioxus-code-editor/web dioxus-code-docsite/web dioxus-code-live-input/web
+      features: dioxus-code/all-languages dioxus-code-docsite/web dioxus-code-live-input/web
 
   test:
     uses: dioxuslabs/dioxus-ci/.github/workflows/test.yml@v0.1.0
     with:
       toolchain: nightly
       no-default-features: true
-      features: dioxus-code/all-languages dioxus-code-editor/web dioxus-code-docsite/web dioxus-code-live-input/web
+      features: dioxus-code/all-languages dioxus-code-docsite/web dioxus-code-live-input/web
 
   clippy:
     uses: dioxuslabs/dioxus-ci/.github/workflows/clippy.yml@v0.1.0
     with:
       toolchain: nightly
       all-features: false
       no-default-features: true
-      features: dioxus-code/all-languages dioxus-code-editor/web dioxus-code-docsite/web dioxus-code-live-input/web
+      features: dioxus-code/all-languages dioxus-code-docsite/web dioxus-code-live-input/web
 
   web-demo:
     uses: dioxuslabs/dioxus-ci/.github/workflows/web-build.yml@v0.1.0

Cargo.toml

@@ -23,7 +23,6 @@ categories = ["gui", "web-programming"]
 [workspace.dependencies]
 dioxus-code = { version = "0.1.1", path = "." }
 dioxus-code-editor = { version = "0.1.2", path = "code-editor", default-features = false }
-betlang = { version = "0.1.0" }
 
 [package]
 name = "dioxus-code"
@@ -44,14 +43,8 @@ rustdoc-args = ["--cfg", "docsrs"]
 [features]
 default = ["macro"]
 macro = ["dep:dioxus-code-macro", "dioxus-code-macro/lang-rust"]
-runtime = [
-    "arborium/lang-rust",
-    "dep:arborium-tree-sitter",
-]
-detection = [
-    "runtime",
-    "dep:betlang",
-]
+runtime = ["arborium/lang-rust", "dep:arborium-tree-sitter"]
+detection = ["runtime", "dep:betlang"]
 all-languages = [
     "runtime",
     "arborium/all-languages",
@@ -268,7 +261,7 @@ arborium-theme = "2.16.0"
 arborium-tree-sitter = { version = "2.16.0", optional = true }
 dioxus = { version = "0.7.0", default-features = false, features = ["lib"] }
 dioxus-code-macro = { version = "0.1.0", path = "dioxus-code-macro", default-features = false, optional = true }
-betlang = { workspace = true, optional = true }
+betlang = { version = "0.1.0", optional = true }
 
 [build-dependencies]
 arborium = { version = "2.16.0", default-features = false }

README.md

@@ -21,8 +21,8 @@ A small Dioxus component for rendering source code with proper highlighting. Par
 
 Two ways to highlight:
 
-- **[`code!`] macro** — parses at compile time. The runtime ships only the spans, no parser. Default.
-- **[`SourceCode`]** — parses at runtime. Opt in with the `runtime` feature when the source isn't known until the user types it.
+- **[`code!`] macro** — parses at compile time and embeds the highlighted spans. Default.
+- **[`SourceCode`]** — parses at runtime. Opt in with the `runtime` feature for dynamic source text.
 
 ## Quick start
 
@@ -51,35 +51,32 @@ When the file extension is ambiguous, pass [`CodeOptions::builder`] with [`CodeO
 
 ## Runtime highlighting
 
-For editor-style use cases where the source isn't known at compile time:
+For editor-style use cases with dynamic source text:
 
 ```toml
 [dependencies]
-dioxus-code = { version = "0.1", features = ["runtime", "detection"] }
+dioxus-code = { version = "0.1", features = ["runtime"] }
 ```
 
 ```rust
-# #[cfg(feature = "detection")]
-# {
 # use dioxus::prelude::*;
 use dioxus_code::{Code, Language, SourceCode, Theme};
 # let user_input = String::new();
 # let _ =
 rsx! {
     Code {
-        src: SourceCode::builder(user_input).with_language(Language::Auto),
+        src: SourceCode::new(Language::Rust, user_input),
         theme: Theme::GITHUB_LIGHT,
     }
 }
 # ;
-# }
 ```
 
-`Language::Auto` is available only with the `detection` feature. Without detection, pass a concrete language such as `Language::Rust`. The default `runtime` feature includes Rust; pass `lang-python`, `lang-toml`, or `all-languages` for the rest.
+Pass a [`Language`] variant when building [`SourceCode`]. The `runtime` feature includes Rust; enable the matching `lang-*` feature, or `all-languages`, for additional grammars.
 
 ## Editor
 
-[`dioxus-code-editor`] is a sibling crate that pairs the highlighter with a `contenteditable` input layer:
+[`dioxus-code-editor`] is a sibling crate that pairs the highlighter with a textarea input layer:
 
 ```rust
 # use dioxus::prelude::*;
@@ -133,7 +130,7 @@ Code {
 
 ```sh
 dx serve --example dioxus-code-basic       # macro + runtime side by side
-dx serve --example dioxus-code-macro-only  # compile-time only, no parser in the binary
+dx serve --example dioxus-code-macro-only  # compile-time highlighted spans
 dx serve --example dioxus-code-live-input  # textarea bound to runtime highlighter
 ```
 

code-editor/Cargo.toml

@@ -17,7 +17,7 @@ targets = ["x86_64-unknown-linux-gnu", "wasm32-unknown-unknown"]
 
 [dependencies]
 dioxus = { version = "0.7.0", default-features = false, features = ["lib"] }
-dioxus-code = { workspace = true, features = ["detection", "lang-toml", "lang-python"] }
+dioxus-code = { workspace = true, features = ["runtime"] }
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
 wasm-bindgen = "0.2"
@@ -30,6 +30,4 @@ web-sys = { version = "0.3", features = [
 ] }
 
 [features]
-default = ["desktop"]
-desktop = ["dioxus/desktop", "dioxus/launch"]
-web = ["dioxus/web", "dioxus/launch"]
+all-languages = ["dioxus-code/all-languages"]

code-editor/README.md

@@ -53,7 +53,7 @@ The component is controlled — drive [`CodeEditorProps::value`] from your own s
 | prop | description |
 |---|---|
 | [`CodeEditorProps::value`] | Current editor contents. |
-| [`CodeEditorProps::language`] | Tree-sitter grammar selection. Pass a [`Language`] variant (for example [`Language::Rust`]) or use [`Language::from_slug`] for custom slugs. |
+| [`CodeEditorProps::language`] | Syntax grammar selection. Pass a [`Language`] variant (for example [`Language::Rust`]) or use [`Language::from_slug`] for runtime slugs. |
 | [`CodeEditorProps::theme`] | Syntax theme selection shared with [`dioxus-code`](https://crates.io/crates/dioxus-code); accepts [`Theme`] or [`CodeTheme`]. |
 | [`CodeEditorProps::line_numbers`] | Show a one-based line gutter. Defaults to `true`. |
 | [`CodeEditorProps::read_only`] | Disable editing while preserving highlighting. |

code-editor/src/lib.rs

@@ -5,7 +5,7 @@ use dioxus::prelude::*;
 pub use dioxus_code::Language;
 #[cfg(test)]
 use dioxus_code::Theme;
-use dioxus_code::advanced::{Buffer, CodeThemeStyles, TokenSpan};
+use dioxus_code::advanced::{Buffer, CodeThemeStyles, HighlightError, TokenSpan};
 #[cfg(test)]
 use dioxus_code::advanced::{HighlightSegment, HighlightedSource};
 use dioxus_code::{CodeTheme, SourceCode};
@@ -71,6 +71,11 @@ pub struct CodeEditorProps {
     pub oninput: EventHandler<String>,
 }
 
+struct EditorBuffer {
+    buffer: Option<Buffer>,
+    language: Language,
+}
+
 /// Editable syntax-highlighted code surface.
 ///
 /// The component is controlled by [`CodeEditorProps::value`]; update that value
@@ -96,10 +101,15 @@ pub struct CodeEditorProps {
 /// ```
 #[component]
 pub fn CodeEditor(props: CodeEditorProps) -> Element {
-    let buffer = use_hook({
+    let state = use_hook({
         let value = props.value.clone();
         let language = props.language;
-        move || Rc::new(RefCell::new(Buffer::new(language, value).ok()))
+        move || {
+            Rc::new(RefCell::new(EditorBuffer {
+                buffer: Buffer::new(language, value).ok(),
+                language,
+            }))
+        }
     });
     let edit_tracker = use_hook(|| {
         Rc::new(RefCell::new(edit_capture::InputEditTracker::new(
@@ -109,28 +119,30 @@ pub fn CodeEditor(props: CodeEditorProps) -> Element {
 
     let edit = edit_tracker.borrow_mut().take_for_render(&props.value);
     let snapshot = {
-        let mut buffer_slot = buffer.borrow_mut();
-        if buffer_slot.is_none() {
-            *buffer_slot = Buffer::new(props.language, props.value.clone()).ok();
+        let mut slot = state.borrow_mut();
+        if slot.language != props.language {
+            slot.buffer = Buffer::new(props.language, props.value.clone()).ok();
+            slot.language = props.language;
         }
 
-        match buffer_slot.as_mut() {
+        match slot.buffer.as_mut() {
             Some(buffer) => {
-                if buffer.language() != props.language {
-                    let _ = buffer.set_language(props.language);
-                }
                 if buffer.source() != props.value {
                     let result = match edit {
-                        Some(edit) => buffer.edit(edit, props.value.clone()),
+                        Some(edit) => match buffer.edit(edit, props.value.clone()) {
+                            Ok(()) => Ok(()),
+                            Err(HighlightError::InvalidEdit { .. }) => {
+                                buffer.replace(props.value.clone())
+                            }
+                            Err(error) => Err(error),
+                        },
                         None => buffer.replace(props.value.clone()),
                     };
                     let _ = result;
                 }
                 buffer.highlighted()
             }
-            None => SourceCode::builder(props.value.clone())
-                .with_language(props.language)
-                .into(),
+            None => SourceCode::new(props.language, props.value.clone()).into(),
         }
     };
     let lines = snapshot.lines();

code-editor/src/main.rs

@@ -19,7 +19,7 @@
 
 Implementation crate for the [`code!`] macro re-exported by [`dioxus-code`](https://crates.io/crates/dioxus-code) under its default `macro` feature. You usually depend on `dioxus-code` instead of pulling this in directly.
 
-The macro reads a source file at compile time, parses it with [`arborium`](https://crates.io/crates/arborium), and expands to a static span tree. The runtime binary ships only the spans — no parser.
+The macro reads a source file at compile time, parses it with [`arborium`](https://crates.io/crates/arborium), and expands to a static span tree that can be rendered by `dioxus-code`.
 
 ```rust
 use dioxus_code::code;

dioxus-code-macro/README.md

@@ -11,7 +11,7 @@ publish = false
 
 [dependencies]
 dioxus = { version = "0.7.0", features = ["router"] }
-dioxus-code = { workspace = true, features = ["all-languages", "detection"] }
+dioxus-code = { workspace = true, features = ["runtime", "lang-toml"] }
 dioxus-code-editor = { workspace = true }
 dioxus-primitives = { git = "https://github.com/DioxusLabs/components", version = "0.0.1", default-features = false, features = ["router"] }