Add retention days to bundle smoke workflow (#5520)

* add retention days to bundle smoke

* fix ci

Author: ealmloff

.github/workflows/main.yml

@@ -210,14 +210,15 @@ jobs:
           test -n "$(find target -name '*.deb' -print -quit)"
           test -n "$(find target -name '*.rpm' -print -quit)"
       - uses: actions/upload-artifact@v6
-        if: always()
+        if: failure()
         with:
           name: hotdog-linux-bundles
           path: |
             target/**/*.AppImage
             target/**/*.deb
             target/**/*.rpm
           if-no-files-found: ignore
+          retention-days: 7
 
   bundle-macos-smoke:
     needs: check-paths
@@ -244,13 +245,14 @@ jobs:
           test -n "$(find target -type d -name '*.app' -print -quit)"
           test -n "$(find target -type f -name '*.dmg' -print -quit)"
       - uses: actions/upload-artifact@v6
-        if: always()
+        if: failure()
         with:
           name: hotdog-macos-bundles
           path: |
             target/**/*.app
             target/**/*.dmg
           if-no-files-found: ignore
+          retention-days: 7
 
   windows-bundle-smoke:
     needs: check-paths
@@ -301,13 +303,14 @@ jobs:
       #   run: |
       #     Get-ChildItem -Path "$env:DIOXUS_WORKSPACE\target" -Recurse -Include "*.pdb","*.exe","*.dll" | Remove-Item -Force
       - uses: actions/upload-artifact@v6
-        if: always()
+        if: failure()
         with:
           name: hotdog-windows-bundles-smoke
           path: |
             ${{ env.DIOXUS_WORKSPACE }}/target/**/*.msi
             ${{ env.DIOXUS_WORKSPACE }}/target/**/*-setup.exe
           if-no-files-found: ignore
+          retention-days: 7
 
   windows:
     needs: check-paths
@@ -351,11 +354,11 @@ jobs:
       #   run: |
       #     Get-ChildItem -Path "$env:DIOXUS_WORKSPACE\target" -Recurse -Include "*.pdb","*.exe","*.dll" | Remove-Item -Force
       - uses: actions/upload-artifact@v6
-        if: always()
+        if: failure()
         with:
           name: playwright-report-windows
           path: ${{ env.DIOXUS_WORKSPACE }}/packages/playwright-tests/playwright-report/
-          retention-days: 30
+          retention-days: 7
 
 
   playwright:
@@ -410,11 +413,11 @@ jobs:
           npx playwright install
           npx playwright test
       - uses: actions/upload-artifact@v6
-        if: always()
+        if: failure()
         with:
           name: playwright-report-${{ matrix.toolchain }}-${{ runner.os }}
           path: ./packages/playwright-tests/playwright-report/
-          retention-days: 30
+          retention-days: 7
 
 
 

packages/core-macro/src/props/mod.rs

@@ -946,7 +946,7 @@ Finally, call `.build()` to create the instance of `{name}`.
 
             let field_name = field.extends_vec_ident().unwrap();
 
-            let descructuring = self.included_fields().map(|f| {
+            let destructuring = self.included_fields().map(|f| {
                 let name = f.name;
                 quote!(#name)
             });
@@ -1048,7 +1048,7 @@ Finally, call `.build()` to create the instance of `{name}`.
                         ____attr: impl dioxus_core::IntoAttributeValue<L>,
                         ____volatile: bool
                     ) -> Self {
-                        let ( #(#descructuring,)* ) = self.fields;
+                        let ( #(#destructuring,)* ) = self.fields;
                         self.#field_name.push(
                             dioxus_core::Attribute::new(
                                 ____name,
@@ -1084,7 +1084,7 @@ Finally, call `.build()` to create the instance of `{name}`.
                 ref builder_name, ..
             } = *self;
 
-            let descructuring = self.included_fields().map(|f| {
+            let destructuring = self.included_fields().map(|f| {
                 if f.ordinal == field.ordinal {
                     quote!(_)
                 } else {
@@ -1214,7 +1214,7 @@ Finally, call `.build()` to create the instance of `{name}`.
                     #[allow(clippy::type_complexity)]
                     pub fn #field_name < #marker > (self, #field_name: #arg_type) -> #builder_name < #( #target_generics ),* > {
                         let #field_name = (#arg_expr,);
-                        let ( #(#descructuring,)* ) = self.fields;
+                        let ( #(#destructuring,)* ) = self.fields;
                         #builder_name {
                             #(#forward_fields,)*
                             fields: ( #(#reconstructing,)* ),
@@ -1410,7 +1410,7 @@ Finally, call `.build()` to create the instance of `{name}`.
                 );
             });
 
-            let descructuring = self.included_fields().map(|f| f.name);
+            let destructuring = self.included_fields().map(|f| f.name);
 
             let helper_trait_name = &self.conversion_helper_trait_name;
             // The default of a field can refer to earlier-defined fields, which we handle by
@@ -1530,7 +1530,7 @@ Finally, call `.build()` to create the instance of `{name}`.
                     impl #impl_generics #builder_name #modified_ty_generics #where_clause {
                         #doc
                         pub fn build(self) -> #name #ty_generics {
-                            let ( #(#descructuring,)* ) = self.fields;
+                            let ( #(#destructuring,)* ) = self.fields;
                             #( #assignments )*
                             #name {
                                 inner: #original_name {
@@ -1547,7 +1547,7 @@ Finally, call `.build()` to create the instance of `{name}`.
                     impl #impl_generics #builder_name #modified_ty_generics #where_clause {
                         #doc
                         pub fn build(self) -> #name #ty_generics {
-                            let ( #(#descructuring,)* ) = self.fields;
+                            let ( #(#destructuring,)* ) = self.fields;
                             #( #assignments )*
                             #name {
                                 #( #field_names ),*