-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Content hash based filename is disabled when --wasm-split is present #5339
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Problem
When invoking dx bundle --wasm-split, content-hash-based filename is not used.
Steps To Reproduce
Steps to reproduce the behavior:
dx bundle --wasm-split
Expected behavior
All assets files (html, css, js, wasm) has a content hash part.
Screenshots
Not applicable
Environment:
- Dioxus version: 0.7.2
- Rust version: 1.92.0
- OS info: Linux
- App platform: web
Questionnaire
I don't have time to fix this now, but I roughly know the way to fix (because claude told me):
In /Users/ken/Projects/dioxus/packages/cli/src/build/request.rs, Line 3998-4000:
fn should_bundle_to_asset(&self) -> bool {
self.release && !self.wasm_split && self.bundle == BundleFormat::Web
}We should remove && !self.wasm_split here. According to claude's analysis, this won't cause any other problems.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working