Conversation
| fn replace_template_placeholders(&self, html: &mut String, wasm_path: &str, js_path: &str) { | ||
| let base_path = self.base_path_or_default(); | ||
| *html = html.replace("{base_path}", base_path); | ||
| *html = html.replace("{base_path}", &format!("/{base_path}")); |
There was a problem hiding this comment.
I'm aware that this is technically a breaking change but I think we should do it as it avoids bugs where these imports only work depending on from where you import. This way they either work all the time or not at all.
|
Is this solving an issue in the tracker? I can't find anything. Why do we need to do this? |
|
Oh sorry for the missing description etc, there is no existing issue. When developing a browser extension using dioxus you are not allowed to use inline JavaScript because of a strict enforced content security policy. See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/content_security_policy for Manifest V3. |
2 participants
No description provided.