Add generic state support to dioxus::server::router#5561
Open
prodbyola wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
dioxus::server::routerto return anaxum::Router<S>with a generic state type instead of justaxum::Routerwhich takes()by default. This allows consumers to attach shared application state using Axum’s with_state pattern.Motivation
Currently, there is no straightforward way to pass shared state (e.g. database pools, configuration, or services) into handlers when using
dioxus::server::router. Since Dioxus server integration is built on top of Axum, enabling generic state aligns with standard Axum patterns and improves interoperability.Changes
Updated router signature to:
Preserved existing behavior while allowing callers to attach state via
.with_state(...)Example usage
Benefits
Enables clean dependency injection for server functions
Aligns with Axum’s standard state management model
Removes need for global state or workarounds like thread_local!
Improves ergonomics for real-world apps (e.g. SQLx, Redis, config)
Notes
No breaking changes for existing users who don’t use state
Type inference works seamlessly in most cases
Happy to adjust