Merge pull request #87 from sertxudev/sertxudev/failing-test

Fake mailbox queries fail when adding any query clauses

Author: stevebauman

src/MessageQuery.php

@@ -13,18 +13,16 @@
 use DirectoryTree\ImapEngine\Enums\ImapFlag;
 use DirectoryTree\ImapEngine\Exceptions\ImapCommandException;
 use DirectoryTree\ImapEngine\Pagination\LengthAwarePaginator;
-use DirectoryTree\ImapEngine\Support\ForwardsCalls;
 use DirectoryTree\ImapEngine\Support\Str;
 use Illuminate\Support\Collection;
 use Illuminate\Support\ItemNotFoundException;
-use Illuminate\Support\Traits\Conditionable;
 
 /**
  * @mixin \DirectoryTree\ImapEngine\Connection\ImapQueryBuilder
  */
 class MessageQuery implements MessageQueryInterface
 {
-    use Conditionable, ForwardsCalls, QueriesMessages;
+    use QueriesMessages;
 
     /**
      * Constructor.

src/QueriesMessages.php

@@ -3,9 +3,13 @@
 namespace DirectoryTree\ImapEngine;
 
 use DirectoryTree\ImapEngine\Connection\ImapQueryBuilder;
+use DirectoryTree\ImapEngine\Support\ForwardsCalls;
+use Illuminate\Support\Traits\Conditionable;
 
 trait QueriesMessages
 {
+    use Conditionable, ForwardsCalls;
+
     /**
      * The query builder instance.
      */

src/Testing/FakeMessageQuery.php

@@ -3,6 +3,7 @@
 namespace DirectoryTree\ImapEngine\Testing;
 
 use DirectoryTree\ImapEngine\Collections\MessageCollection;
+use DirectoryTree\ImapEngine\Connection\ImapQueryBuilder;
 use DirectoryTree\ImapEngine\Enums\ImapFetchIdentifier;
 use DirectoryTree\ImapEngine\MessageInterface;
 use DirectoryTree\ImapEngine\MessageQueryInterface;
@@ -17,7 +18,8 @@ class FakeMessageQuery implements MessageQueryInterface
      * Constructor.
      */
     public function __construct(
-        protected FakeFolder $folder
+        protected FakeFolder $folder,
+        protected ImapQueryBuilder $query = new ImapQueryBuilder
     ) {}
 
     /**

tests/Unit/Testing/FakeFolderTest.php

@@ -71,6 +71,7 @@
 
 test('it can set mailbox', function () {
     $folder = new FakeFolder('INBOX');
+
     $mailbox = new FakeMailbox(['host' => 'imap.example.com']);
 
     $folder->setMailbox($mailbox);
@@ -80,9 +81,11 @@
 
 test('it can set messages', function () {
     $folder = new FakeFolder('INBOX');
-    $messages = [new FakeMessage(1), new FakeMessage(2)];
 
-    $folder->setMessages($messages);
+    $folder->setMessages([
+        new FakeMessage(1),
+        new FakeMessage(2),
+    ]);
 
     expect($folder->messages()->count())->toBe(2);
 });
@@ -94,3 +97,17 @@
 
     expect($folder->delimiter())->toBe('.');
 });
+
+test('it can query messages from a fake mailbox folder', function () {
+    $folder = new FakeFolder('inbox', ['\\HasNoChildren'], [
+        new FakeMessage(1, [''], 'Message 1'),
+        new FakeMessage(2, [''], 'Message 2'),
+        new FakeMessage(3, ['\\Seen'], 'Message 3'),
+    ]);
+
+    // These should all have the same count because
+    // no filtering should actually take place
+    expect($folder->messages()->count())->toBe(3);
+    expect($folder->messages()->where('Unseen')->count())->toBe(3);
+    expect($folder->messages()->where('Seen')->count())->toBe(3);
+});