Move bulk index payload onto document

Author: stevebauman

src/Documents/Document.php

@@ -44,6 +44,25 @@ public function get(string $key): mixed
         return $this->source[$key] ?? null;
     }
 
+    /**
+     * Get the OpenSearch bulk index operation payload.
+     *
+     * @return array{0: array{index: array<string, string>}, 1: array<string, mixed>}
+     */
+    public function toBulkIndex(?string $routing = null): array
+    {
+        $index = ['_id' => $this->id];
+
+        if (! is_null($routing)) {
+            $index['routing'] = $routing;
+        }
+
+        return [
+            compact('index'),
+            $this->source,
+        ];
+    }
+
     /**
      * Get the array representation of the document.
      *

src/Documents/DocumentManager.php

@@ -41,14 +41,10 @@ public function index(
         ];
 
         foreach ($documents as $document) {
-            $index = ['_id' => $document->id()];
-
-            if ($routing && $routing->has($document->id())) {
-                $index['routing'] = $routing->get($document->id());
-            }
-
-            $params['body'][] = compact('index');
-            $params['body'][] = $document->source();
+            array_push(
+                $params['body'],
+                ...$document->toBulkIndex($routing?->get($document->id()))
+            );
         }
 
         $response = $this->client->bulk($params);

tests/Unit/Documents/DocumentTest.php

@@ -21,3 +21,21 @@
         'source' => ['title' => 'test'],
     ], $document->toArray());
 });
+
+test('bulk index payload can be retrieved', function () {
+    $document = new Document('1', ['title' => 'test']);
+
+    $this->assertSame([
+        ['index' => ['_id' => '1']],
+        ['title' => 'test'],
+    ], $document->toBulkIndex());
+});
+
+test('bulk index payload can be retrieved with routing', function () {
+    $document = new Document('1', ['title' => 'test']);
+
+    $this->assertSame([
+        ['index' => ['_id' => '1', 'routing' => 'tenant-1']],
+        ['title' => 'test'],
+    ], $document->toBulkIndex('tenant-1'));
+});