Remove test callback return types

Author: stevebauman

tests/Integration/Console/FreshCommandTest.php

@@ -7,7 +7,7 @@
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\NullOutput;
 
-it('drops indices and migrations', function (): void {
+it('drops indices and migrations', function () {
     $migrator = Mockery::mock(Migrator::class);
     $repository = Mockery::mock(MigrationRepository::class);
     $index = Mockery::mock(IndexManagerInterface::class);

tests/Integration/Console/MakeCommandTest.php

@@ -5,7 +5,7 @@
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\BufferedOutput;
 
-it('creates migration files', function (): void {
+it('creates migration files', function () {
     $migrations = Mockery::mock(MigrationStorage::class);
     app()->instance(MigrationStorage::class, $migrations);
 

tests/Integration/Console/MigrateCommandTest.php

@@ -5,7 +5,7 @@
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\NullOutput;
 
-it('runs one migration when a file name is provided', function (): void {
+it('runs one migration when a file name is provided', function () {
     $migrator = Mockery::mock(Migrator::class);
     app()->instance(Migrator::class, $migrator);
 
@@ -20,7 +20,7 @@
     expect($command->run(new ArrayInput(['--force' => true, 'fileName' => 'test_file_name']), new NullOutput))->toBe(0);
 });
 
-it('runs all migrations when a file name is not provided', function (): void {
+it('runs all migrations when a file name is not provided', function () {
     $migrator = Mockery::mock(Migrator::class);
     app()->instance(Migrator::class, $migrator);
 

tests/Integration/Console/RefreshCommandTest.php

@@ -5,7 +5,7 @@
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\NullOutput;
 
-it('resets and reruns all migrations', function (): void {
+it('resets and reruns all migrations', function () {
     $migrator = Mockery::mock(Migrator::class);
     app()->instance(Migrator::class, $migrator);
 

tests/Integration/Console/ResetCommandTest.php

@@ -5,7 +5,7 @@
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\NullOutput;
 
-it('rolls back all migrations', function (): void {
+it('rolls back all migrations', function () {
     $migrator = Mockery::mock(Migrator::class);
     app()->instance(Migrator::class, $migrator);
 

tests/Integration/Console/RollbackCommandTest.php

@@ -5,7 +5,7 @@
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\NullOutput;
 
-it('rolls back one migration when a file name is provided', function (): void {
+it('rolls back one migration when a file name is provided', function () {
     $migrator = Mockery::mock(Migrator::class);
     app()->instance(Migrator::class, $migrator);
 
@@ -20,7 +20,7 @@
     expect($command->run(new ArrayInput(['--force' => true, 'fileName' => 'test_file_name']), new NullOutput))->toBe(0);
 });
 
-it('rolls back the last batch when a file name is not provided', function (): void {
+it('rolls back the last batch when a file name is not provided', function () {
     $migrator = Mockery::mock(Migrator::class);
     app()->instance(Migrator::class, $migrator);
 

tests/Integration/Console/StatusCommandTest.php

@@ -5,7 +5,7 @@
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\NullOutput;
 
-it('shows migration status', function (): void {
+it('shows migration status', function () {
     $migrator = Mockery::mock(Migrator::class);
     app()->instance(Migrator::class, $migrator);
 

tests/Integration/Factories/MigrationFactoryTest.php

@@ -4,7 +4,7 @@
 use DirectoryTree\OpenSearchMigrations\Filesystem\MigrationStorage;
 use DirectoryTree\OpenSearchMigrations\MigrationInterface;
 
-it('creates migrations from files', function (string $fileName): void {
+it('creates migrations from files', function (string $fileName) {
     $file = resolve(MigrationStorage::class)->find($fileName);
 
     expect(resolve(MigrationFactory::class)->makeFromFile($file))->toBeInstanceOf(MigrationInterface::class);

tests/Integration/Filesystem/MigrationStorageTest.php

@@ -3,7 +3,7 @@
 use DirectoryTree\OpenSearchMigrations\Filesystem\MigrationFile;
 use DirectoryTree\OpenSearchMigrations\Filesystem\MigrationStorage;
 
-it('creates files', function (): void {
+it('creates files', function () {
     $storage = resolve(MigrationStorage::class);
     $fileName = uniqid();
 
@@ -16,7 +16,7 @@
     @unlink($file->path());
 });
 
-it('creates the directory along with the file', function (): void {
+it('creates the directory along with the file', function () {
     $directory = config('opensearch-migrations.storage_directory');
     $firstLevelDirectory = $directory.'/nested';
     $secondLevelDirectory = $firstLevelDirectory.'/directories';
@@ -33,15 +33,15 @@
     @rmdir($firstLevelDirectory);
 });
 
-it('prepares when the directory exists', function (): void {
+it('prepares when the directory exists', function () {
     $directory = config('opensearch-migrations.storage_directory');
 
     resolve(MigrationStorage::class)->prepare();
 
     expect($directory)->toBeDirectory();
 });
 
-it('creates the directory when preparing', function (): void {
+it('creates the directory when preparing', function () {
     $directory = sys_get_temp_dir().'/opensearch_migrations_missing_storage';
 
     config()->set('opensearch-migrations.storage_directory', $directory);
@@ -53,7 +53,7 @@
     @rmdir($directory);
 });
 
-it('finds existing files', function (string $fileName): void {
+it('finds existing files', function (string $fileName) {
     $file = resolve(MigrationStorage::class)->find($fileName);
 
     expect($file)->toBeInstanceOf(MigrationFile::class);
@@ -65,7 +65,7 @@
     ['2019_08_10_142230_update_test_index_mapping.php'],
 ]);
 
-it('does not find missing files', function (string $fileName): void {
+it('does not find missing files', function (string $fileName) {
     expect(resolve(MigrationStorage::class)->find($fileName))->toBeNull();
 })->with([
     ['2020_12_01_081000_create_test_index'],
@@ -74,7 +74,7 @@
     ['2020_08_10_142230_update_test_index_mapping.php'],
 ]);
 
-it('retrieves all migration files', function (): void {
+it('retrieves all migration files', function () {
     $files = resolve(MigrationStorage::class)->all();
 
     expect($files->map(fn (MigrationFile $file) => $file->name())->toArray())->toBe([

tests/Integration/MigratorTest.php

@@ -34,7 +34,7 @@ function outputExpectingLines(array $lines): OutputStyle
     return $output;
 }
 
-it('does not run a missing single migration', function (): void {
+it('does not run a missing single migration', function () {
     $output = outputExpectingLines([
         '<error>Migration is not found:</error> 3020_11_01_045023_drop_test_index',
     ]);
@@ -44,7 +44,7 @@ function outputExpectingLines(array $lines): OutputStyle
     expect($migrator->migrateOne('3020_11_01_045023_drop_test_index'))->toBe($migrator);
 });
 
-it('runs a single migration when it exists', function (): void {
+it('runs a single migration when it exists', function () {
     Index::shouldReceive('putMapping')->once();
 
     $output = outputExpectingLines([
@@ -61,7 +61,7 @@ function outputExpectingLines(array $lines): OutputStyle
     ])->exists())->toBeTrue();
 });
 
-it('does not run all migrations when the directory is empty', function (): void {
+it('does not run all migrations when the directory is empty', function () {
     $tmpDirectory = config('opensearch-migrations.storage_directory').'/tmp';
 
     @mkdir($tmpDirectory);
@@ -78,7 +78,7 @@ function outputExpectingLines(array $lines): OutputStyle
     @rmdir($tmpDirectory);
 });
 
-it('runs all outstanding migrations', function (): void {
+it('runs all outstanding migrations', function () {
     Index::shouldReceive('putMapping')->once();
 
     $output = outputExpectingLines([
@@ -95,7 +95,7 @@ function outputExpectingLines(array $lines): OutputStyle
     ])->exists())->toBeTrue();
 });
 
-it('does not roll back a missing single migration', function (): void {
+it('does not roll back a missing single migration', function () {
     $output = outputExpectingLines([
         '<error>Migration is not found:</error> 3020_11_01_045023_drop_test_index',
     ]);
@@ -105,7 +105,7 @@ function outputExpectingLines(array $lines): OutputStyle
     expect($migrator->rollbackOne('3020_11_01_045023_drop_test_index'))->toBe($migrator);
 });
 
-it('does not roll back a migration that has not run', function (): void {
+it('does not roll back a migration that has not run', function () {
     $output = outputExpectingLines([
         '<error>Migration is not yet migrated:</error> 2019_08_10_142230_update_test_index_mapping',
     ]);
@@ -115,7 +115,7 @@ function outputExpectingLines(array $lines): OutputStyle
     expect($migrator->rollbackOne('2019_08_10_142230_update_test_index_mapping'))->toBe($migrator);
 });
 
-it('rolls back a migrated single migration', function (): void {
+it('rolls back a migrated single migration', function () {
     Index::shouldReceive('drop')->once();
 
     $output = outputExpectingLines([
@@ -132,7 +132,7 @@ function outputExpectingLines(array $lines): OutputStyle
     ])->exists())->toBeFalse();
 });
 
-it('does not roll back the last batch when some files are missing', function (): void {
+it('does not roll back the last batch when some files are missing', function () {
     $output = outputExpectingLines([
         '<error>Migration is not found:</error> 2019_03_10_101500_create_test_index',
     ]);
@@ -146,7 +146,7 @@ function outputExpectingLines(array $lines): OutputStyle
     expect($migrator->rollbackLastBatch())->toBe($migrator);
 });
 
-it('rolls back the last batch when all files are present', function (): void {
+it('rolls back the last batch when all files are present', function () {
     Index::shouldReceive('putMapping')->once();
 
     $output = outputExpectingLines([
@@ -167,7 +167,7 @@ function outputExpectingLines(array $lines): OutputStyle
     ])->exists())->toBeFalse();
 });
 
-it('does not roll back all migrations when some files are missing', function (): void {
+it('does not roll back all migrations when some files are missing', function () {
     $output = outputExpectingLines([
         '<error>Migration is not found:</error> 2019_03_10_101500_create_test_index,2019_01_01_053550_drop_test_index',
     ]);
@@ -182,7 +182,7 @@ function outputExpectingLines(array $lines): OutputStyle
     expect($migrator->rollbackAll())->toBe($migrator);
 });
 
-it('rolls back all migrations when all files are present', function (): void {
+it('rolls back all migrations when all files are present', function () {
     Index::shouldReceive('putMapping')->once();
     Index::shouldReceive('drop')->once();
 
@@ -204,7 +204,7 @@ function outputExpectingLines(array $lines): OutputStyle
     expect(DB::table($table)->where('migration', '2018_12_01_081000_create_test_index')->exists())->toBeFalse();
 });
 
-it('displays status', function (): void {
+it('displays status', function () {
     $output = Mockery::mock(OutputStyle::class);
 
     $output->shouldReceive('table')->once()->with(
@@ -220,13 +220,13 @@ function outputExpectingLines(array $lines): OutputStyle
     expect($migrator->showStatus())->toBe($migrator);
 });
 
-it('prepares the repository and storage', function (): void {
+it('prepares the repository and storage', function () {
     [, $migrator] = seededMigrator(Mockery::mock(OutputStyle::class));
 
     expect($migrator->prepare())->toBe($migrator);
 });
 
-it('creates the repository table when preparing', function (): void {
+it('creates the repository table when preparing', function () {
     $output = Mockery::mock(OutputStyle::class);
     [$table, $migrator] = seededMigrator($output);
 
@@ -236,7 +236,7 @@ function outputExpectingLines(array $lines): OutputStyle
     expect(Schema::hasTable($table))->toBeTrue();
 });
 
-it('creates the storage directory when preparing', function (): void {
+it('creates the storage directory when preparing', function () {
     $directory = sys_get_temp_dir().'/opensearch_migrations_missing_directory';
 
     config()->set('opensearch-migrations.storage_directory', $directory);