Replace readiness checks with preparation

Author: stevebauman

src/Console/FreshCommand.php

@@ -36,10 +36,12 @@ public function handle(
     ): int {
         $migrator->setOutput($this->output);
 
-        if (! $this->confirmToProceed() || ! $migrator->isReady()) {
+        if (! $this->confirmToProceed()) {
             return 1;
         }
 
+        $migrator->prepare();
+
         $index->drop('*');
 
         $migrations->deleteAll();

src/Console/MigrateCommand.php

@@ -36,10 +36,12 @@ public function handle(Migrator $migrator): int
     {
         $migrator->setOutput($this->output);
 
-        if (! $this->confirmToProceed() || ! $migrator->isReady()) {
+        if (! $this->confirmToProceed()) {
             return 1;
         }
 
+        $migrator->prepare();
+
         if ($fileName = $this->argument('fileName')) {
             $migrator->migrateOne($fileName);
         } else {

src/Console/RefreshCommand.php

@@ -35,10 +35,12 @@ public function handle(Migrator $migrator): int
     {
         $migrator->setOutput($this->output);
 
-        if (! $this->confirmToProceed() || ! $migrator->isReady()) {
+        if (! $this->confirmToProceed()) {
             return 1;
         }
 
+        $migrator->prepare();
+
         $migrator->rollbackAll();
         $migrator->migrateAll();
 

src/Console/ResetCommand.php

@@ -35,10 +35,12 @@ public function handle(Migrator $migrator): int
     {
         $migrator->setOutput($this->output);
 
-        if (! $this->confirmToProceed() || ! $migrator->isReady()) {
+        if (! $this->confirmToProceed()) {
             return 1;
         }
 
+        $migrator->prepare();
+
         $migrator->rollbackAll();
 
         return 0;

src/Console/RollbackCommand.php

@@ -36,10 +36,12 @@ public function handle(Migrator $migrator): int
     {
         $migrator->setOutput($this->output);
 
-        if (! $this->confirmToProceed() || ! $migrator->isReady()) {
+        if (! $this->confirmToProceed()) {
             return 1;
         }
 
+        $migrator->prepare();
+
         if ($fileName = $this->argument('fileName')) {
             $migrator->rollbackOne($fileName);
         } else {

src/Console/StatusCommand.php

@@ -31,10 +31,7 @@ public function handle(Migrator $migrator): int
     {
         $migrator->setOutput($this->output);
 
-        if (! $migrator->isReady()) {
-            return 1;
-        }
-
+        $migrator->prepare();
         $migrator->showStatus();
 
         return 0;

src/Filesystem/MigrationStorage.php

@@ -2,14 +2,13 @@
 
 namespace DirectoryTree\OpenSearchMigrations\Filesystem;
 
-use DirectoryTree\OpenSearchMigrations\ReadinessInterface;
 use Illuminate\Filesystem\Filesystem;
 use Illuminate\Support\Collection;
 
 /**
  * Stores and retrieves OpenSearch migration files.
  */
-class MigrationStorage implements ReadinessInterface
+class MigrationStorage
 {
     /**
      * Create a new migration storage instance.
@@ -70,10 +69,10 @@ protected function resolvePath(string $fileName): string
     }
 
     /**
-     * Determine if the migration storage directory exists.
+     * Prepare the migration storage directory.
      */
-    public function isReady(): bool
+    public function prepare(): void
     {
-        return $this->filesystem->isDirectory($this->directory);
+        $this->filesystem->ensureDirectoryExists($this->directory);
     }
 }

src/Migrator.php

@@ -12,7 +12,7 @@
 /**
  * Runs and rolls back OpenSearch migration files.
  */
-class Migrator implements ReadinessInterface
+class Migrator
 {
     /**
      * The console output implementation.
@@ -208,18 +208,13 @@ protected function rollback(Collection $fileNames): self
     }
 
     /**
-     * Determine if migrations can be run.
+     * Prepare the migration repository and storage.
      */
-    public function isReady(): bool
+    public function prepare(): self
     {
-        if (! $isMigrationRepositoryReady = $this->migrationRepository->isReady()) {
-            $this->output->writeln('<error>Migration table is not yet created</error>');
-        }
-
-        if (! $isMigrationStorageReady = $this->migrationStorage->isReady()) {
-            $this->output->writeln('<error>Migration directory is not yet created</error>');
-        }
+        $this->migrationRepository->prepare();
+        $this->migrationStorage->prepare();
 
-        return $isMigrationRepositoryReady && $isMigrationStorageReady;
+        return $this;
     }
 }

src/ReadinessInterface.php

@@ -2,7 +2,6 @@
 
 namespace DirectoryTree\OpenSearchMigrations\Repositories;
 
-use DirectoryTree\OpenSearchMigrations\ReadinessInterface;
 use Illuminate\Database\Query\Builder;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Collection;
@@ -13,7 +12,7 @@
 /**
  * Stores and retrieves executed OpenSearch migration records.
  */
-class MigrationRepository implements ReadinessInterface
+class MigrationRepository
 {
     /**
      * Create a new migration repository instance.
@@ -132,16 +131,14 @@ protected function table(): Builder
     }
 
     /**
-     * Determine if the migration repository is ready.
+     * Prepare the migration repository table.
      */
-    public function isReady(): bool
+    public function prepare(): void
     {
         if (Schema::connection($this->connection)->hasTable($this->table)) {
-            return true;
+            return;
         }
 
         $this->create();
-
-        return true;
     }
 }