Cover migration connection behavior

Author: stevebauman

database/migrations/2019_15_12_112000_create_opensearch_migrations_table.php

@@ -11,7 +11,7 @@
      */
     public function up(): void
     {
-        Schema::create(config('opensearch-migrations.table'), function (Blueprint $table) {
+        Schema::connection(config('opensearch-migrations.connection'))->create(config('opensearch-migrations.table'), function (Blueprint $table) {
             $table->increments('id');
             $table->string('migration');
             $table->integer('batch');
@@ -23,6 +23,6 @@ public function up(): void
      */
     public function down(): void
     {
-        Schema::dropIfExists(config('opensearch-migrations.table'));
+        Schema::connection(config('opensearch-migrations.connection'))->dropIfExists(config('opensearch-migrations.table'));
     }
 };

tests/Integration/Adapters/IndexManagerAdapterTest.php

@@ -207,6 +207,7 @@ public function test_index_can_be_dropped_only_if_exists(string $indexPrefix): v
     #[DataProvider('prefixProvider')]
     public function test_alias_can_be_created(string $aliasNamePrefix): void
     {
+        $this->app['config']->set('opensearch-migrations.index_name_prefix', $aliasNamePrefix);
         $this->app['config']->set('opensearch-migrations.alias_name_prefix', $aliasNamePrefix);
 
         $index = 'foo';
@@ -215,14 +216,15 @@ public function test_alias_can_be_created(string $aliasNamePrefix): void
         $this->indexManagerMock
             ->expects($this->once())
             ->method('putAlias')
-            ->with($index, new Alias($aliasNamePrefix.$aliasName));
+            ->with($aliasNamePrefix.$index, new Alias($aliasNamePrefix.$aliasName));
 
         $this->indexManagerAdapter->putAlias($index, $aliasName);
     }
 
     #[DataProvider('prefixProvider')]
     public function test_alias_can_be_deleted(string $aliasNamePrefix): void
     {
+        $this->app['config']->set('opensearch-migrations.index_name_prefix', $aliasNamePrefix);
         $this->app['config']->set('opensearch-migrations.alias_name_prefix', $aliasNamePrefix);
 
         $index = 'foo';
@@ -231,7 +233,7 @@ public function test_alias_can_be_deleted(string $aliasNamePrefix): void
         $this->indexManagerMock
             ->expects($this->once())
             ->method('deleteAlias')
-            ->with($index, $aliasNamePrefix.$aliasName);
+            ->with($aliasNamePrefix.$index, $aliasNamePrefix.$aliasName);
 
         $this->indexManagerAdapter->deleteAlias($index, $aliasName);
     }

tests/Integration/Repositories/MigrationRepositoryTest.php

@@ -60,6 +60,28 @@ public function test_repository_table_matches_laravel_migration_table_structure(
         $this->assertSame(3, DB::table($this->table)->max('id'));
     }
 
+    public function test_repository_table_migration_uses_configured_database_connection(): void
+    {
+        $this->app['config']->set('database.connections.opensearch_migrations', [
+            'driver' => 'sqlite',
+            'database' => ':memory:',
+        ]);
+
+        $this->app['config']->set('opensearch-migrations.connection', 'opensearch_migrations');
+        $this->app['config']->set('opensearch-migrations.table', 'custom_opensearch_migrations');
+
+        $migration = require dirname(__DIR__, 3).'/database/migrations/2019_15_12_112000_create_opensearch_migrations_table.php';
+
+        $migration->up();
+
+        $this->assertFalse(Schema::hasTable('custom_opensearch_migrations'));
+        $this->assertTrue(Schema::connection('opensearch_migrations')->hasTable('custom_opensearch_migrations'));
+
+        $migration->down();
+
+        $this->assertFalse(Schema::connection('opensearch_migrations')->hasTable('custom_opensearch_migrations'));
+    }
+
     public function test_record_passes_existence_check(): void
     {
         $this->assertTrue($this->migrationRepository->exists('2018_12_01_081000_create_test_index'));

tests/Integration/Support/PrefixTest.php …egration/Support/MigrationPrefixTest.phptests/Integration/Support/PrefixTest.php renamed to tests/Integration/Support/MigrationPrefixTest.php tests/Integration/Support/PrefixTest.php renamed to tests/Integration/Support/MigrationPrefixTest.php

@@ -5,7 +5,7 @@
 use DirectoryTree\OpenSearchMigrations\Support\MigrationPrefix;
 use DirectoryTree\OpenSearchMigrations\Tests\Integration\TestCase;
 
-class PrefixTest extends TestCase
+class MigrationPrefixTest extends TestCase
 {
     public function test_index_names_can_be_prefixed(): void
     {