Clean up install command failures

Author: stevebauman

src/Commands/InstallBinaryCommand.php

@@ -104,9 +104,7 @@ protected function extract(string $archivePath, string $workingDirectory): void
      */
     protected function install(string $workingDirectory, string $binaryPath): void
     {
-        $source = $this->findExtractedBinary($workingDirectory);
-
-        if (is_null($source)) {
+        if (! $source = $this->findExtractedBinary($workingDirectory)) {
             throw new RuntimeException('Unable to locate the privacy-filter binary in the extracted archive.');
         }
 
@@ -168,7 +166,7 @@ protected function getArchiveFileName(string $url, string $fallback): string
     {
         $path = parse_url($url, PHP_URL_PATH);
 
-        if (! is_string($path) || $path === '') {
+        if (! is_string($path) || empty($path)) {
             return $fallback;
         }
 

src/Commands/InstallModelCommand.php

@@ -44,13 +44,7 @@ public function handle(): int
             return self::SUCCESS;
         }
 
-        try {
-            $this->download($url, $modelPath);
-        } catch (RuntimeException $exception) {
-            $this->error($exception->getMessage());
-
-            return self::FAILURE;
-        }
+        $this->download($url, $modelPath);
 
         $this->info('Privacy-filter model installed.');