Refactor vite script compilation (#2887)

* Refactor vite script compilation

Converts the bundling of scripts to generate an IIFE (standard browser compatible) style script instead of a module with a legacy version. This better supports the jquery external dependency that other site scripts rely on.

* update CI workflow minification test

Author: cairocoder01

.github/workflows/ci.yml

@@ -119,6 +119,7 @@ jobs:
       run : |
         find dt-assets/ -iname "*.min.js" -or -iname "*.map" -or -iname "*.min.css" -delete && rm -rf build/
         vite build
+        vite build --config vite.config.scripts.js
         git diff --exit-code -- . ':(exclude)package-lock.json'
 
     - name: Install Subversion

dt-assets/build/css/style.min.css

@@ -1,16 +1,4 @@
 {
-  "dt-assets/js/main-legacy.js": {
-    "file": "js/scripts-legacy.min.js",
-    "name": "scripts",
-    "src": "dt-assets/js/main-legacy.js",
-    "isEntry": true
-  },
-  "dt-assets/js/main.js": {
-    "file": "js/scripts.min.js",
-    "name": "scripts",
-    "src": "dt-assets/js/main.js",
-    "isEntry": true
-  },
   "dt-assets/scss/login.scss": {
     "file": "css/login.min.css",
     "src": "dt-assets/scss/login.scss",
@@ -55,11 +43,5 @@
     "names": [
       "light.css"
     ]
-  },
-  "vite/legacy-polyfills-legacy": {
-    "file": "js/polyfills-legacy.min.js",
-    "name": "polyfills",
-    "src": "vite/legacy-polyfills-legacy",
-    "isEntry": true
   }
 }

dt-assets/build/js/polyfills-legacy.min.js

@@ -78,12 +78,7 @@ function dt_site_scripts() {
     wp_enqueue_script( 'jquery-ui' );
 
     // Register site scripts
-    // Although WP has wp_enqueue_script_module to be able to load scripts.min.js directly as a js module,
-    // WP doesn't let module scripts depend on classic scripts (scripts.min.js depending on jquery) or
-    // vice versa (modular-list.js depending on scripts.min.js). So at least for now, we need to depend on
-    // the legacy scripts that many wp scripts depend on via the 'site-js' handle.
-    dt_theme_enqueue_script( 'site-polyfills', 'dt-assets/build/js/polyfills-legacy.min.js', array( 'jquery' ), true );
-    dt_theme_enqueue_script( 'site-js', 'dt-assets/build/js/scripts-legacy.min.js', array( 'jquery', 'site-polyfills' ), true );
+    dt_theme_enqueue_script( 'site-js', 'dt-assets/build/js/scripts.min.js', array( 'jquery' ), true );
 
     // Register main stylesheet. Enable HMR by loading from vite if possible
     $vite_dev_server_running = false;