Enhance file upload functionality by expanding accepted file types to include various document formats and audio/video types. Refactor related JavaScript and PHP code to improve handling of accepted file types, including the removal of the file type icon feature for a cleaner interface. Update placeholder text and help descriptions for better user guidance on file uploads.

kodinkat · kodinkat · commit 6626ce72abaa · 2026-03-04T14:46:01.000Z
diff --git a/dt-assets/functions/enqueue-scripts.php b/dt-assets/functions/enqueue-scripts.php
@@ -445,12 +445,16 @@ function dt_site_scripts() {
             [
                 'rest_url' => esc_url_raw( rest_url() ),
                 'accepted_file_types' => [
-                    'image/png',
-                    'image/gif',
-                    'image/jpeg',
-                    'image/jpg',
+                    'image/*',
+                    'application/pdf',
                     'audio/*',
-                    'video/*'
+                    'video/*',
+                    'application/msword',
+                    'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
+                    'application/vnd.ms-excel',
+                    'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+                    'text/plain',
+                    'text/markdown',
                 ],
                 'translations' => [
                     'modals' => [
diff --git a/dt-core/admin/admin-settings-endpoints.php b/dt-core/admin/admin-settings-endpoints.php
@@ -1298,9 +1298,15 @@ public static function edit_field( WP_REST_Request $request ) {
             // Upload File Field Types: Field-specific options
             if ( isset( $post_fields[$field_key]['type'] ) && $post_fields[$field_key]['type'] === 'file_upload' ) {
                 // Accepted file types
-                if ( isset( $post_submission['visibility']['accepted_file_types'] ) && !empty( $post_submission['visibility']['accepted_file_types'] ) ) {
-                    $types = array_map( 'sanitize_text_field', array_map( 'trim', explode( ',', $post_submission['visibility']['accepted_file_types'] ) ) );
-                    $custom_field['accepted_file_types'] = $types;
+                if ( isset( $post_submission['visibility']['accepted_file_types'] ) ) {
+                    $raw_accepted = trim( $post_submission['visibility']['accepted_file_types'] );
+                    if ( $raw_accepted === '' ) {
+                        // Clear any previously saved override so defaults are used
+                        unset( $custom_field['accepted_file_types'] );
+                    } else {
+                        $types = array_map( 'sanitize_text_field', array_map( 'trim', explode( ',', $raw_accepted ) ) );
+                        $custom_field['accepted_file_types'] = $types;
+                    }
                 }
 
                 // Max file size
@@ -1310,16 +1316,6 @@ public static function edit_field( WP_REST_Request $request ) {
                     unset( $custom_field['max_file_size'] );
                 }
 
-                // File type icon
-                if ( isset( $post_submission['visibility']['file_type_icon'] ) ) {
-                    $file_type_icon = sanitize_text_field( wp_unslash( $post_submission['visibility']['file_type_icon'] ) );
-                    if ( !empty( $file_type_icon ) ) {
-                        $custom_field['file_type_icon'] = $file_type_icon;
-                    } else {
-                        unset( $custom_field['file_type_icon'] );
-                    }
-                }
-
                 // Delete enabled
                 if ( isset( $post_submission['visibility']['delete_enabled'] ) ) {
                     $custom_field['delete_enabled'] = (bool) $post_submission['visibility']['delete_enabled'];
diff --git a/dt-core/admin/js/dt-settings.js b/dt-core/admin/js/dt-settings.js
@@ -1609,31 +1609,26 @@ jQuery(document).ready(function ($) {
 
     // Add file_upload field-specific options
     if (field_type === 'file_upload') {
-      let accepted_file_types = field_settings['accepted_file_types'] || [
-        'image/*',
-        'application/pdf',
-      ];
+      let accepted_file_types =
+        field_settings['accepted_file_types'] || [
+          'image/*',
+          'application/pdf',
+          'audio/*',
+          'video/*',
+          'application/msword',
+          'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
+          'application/vnd.ms-excel',
+          'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+          'text/plain',
+          'text/markdown',
+        ];
       let max_file_size = field_settings['max_file_size'] || '';
-      let file_type_icon = field_settings['file_type_icon'] || '';
       let delete_enabled = field_settings['delete_enabled'] !== false; // default true
       let display_layout = field_settings['display_layout'] || 'grid';
       let auto_upload = field_settings['auto_upload'] !== false; // default true
       let download_enabled = field_settings['download_enabled'] !== false; // default true
       let rename_enabled = field_settings['rename_enabled'] !== false; // default true
 
-      let file_type_icon_html = '';
-      if (
-        file_type_icon &&
-        typeof file_type_icon !== 'undefined' &&
-        file_type_icon !== 'undefined'
-      ) {
-        if (file_type_icon.trim().toLowerCase().startsWith('mdi')) {
-          file_type_icon_html = `<i class="${file_type_icon} field-icon" style="font-size: 20px; vertical-align: middle;"></i>`;
-        } else {
-          file_type_icon_html = `<img src="${file_type_icon}" class="field-icon" style="vertical-align: middle; max-width: 20px;">`;
-        }
-      }
-
       modal_html_content += `
         <tr>
             <td>
@@ -1642,10 +1637,13 @@ jQuery(document).ready(function ($) {
             <td>
                 <input type="text" name="accepted_file_types" id="accepted_file_types" 
                   value="${accepted_file_types.join(', ')}" 
-                  placeholder="e.g., image/*, application/pdf, .doc, .docx"
+                  placeholder="e.g., image/*, audio/*, video/*, application/pdf, .docx"
                   style="width: 100%;">
                 <p style="font-size: 11px; color: #666; margin-top: 5px;">
-                  Comma-separated list of MIME types or file extensions (e.g., image/*, application/pdf, .doc)
+                  Optional. Comma-separated list of MIME types or file extensions to override the default set (images, PDFs, audio, video, common documents). Leave empty to use the default types.
+                  <a href="https://developer.mozilla.org/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types" target="_blank" rel="noopener noreferrer">
+                    View common MIME types.
+                  </a>
                 </p>
             </td>
         </tr>
@@ -1659,23 +1657,6 @@ jQuery(document).ready(function ($) {
                   placeholder="Leave empty for no limit">
             </td>
         </tr>
-        <tr>
-            <td>
-                <label for="file_type_icon"><b>File Type Icon</b></label>
-            </td>
-            <td>
-                <div class="input-group">
-                    ${file_type_icon_html}
-                    <input name="file_type_icon" id="file_type_icon" type="text" 
-                      value="${file_type_icon}" style="vertical-align: middle;">
-                    <button class="button change-icon-button" style="vertical-align: middle;"
-                            data-icon-input="file_type_icon">Select Icon</button>
-                </div>
-                <p style="font-size: 11px; color: #666; margin-top: 5px;">
-                  Icon to display for non-image files (e.g., PDFs, documents)
-                </p>
-            </td>
-        </tr>
         <tr>
             <td>
                 <b>Delete Enabled</b>
@@ -2445,7 +2426,6 @@ jQuery(document).ready(function ($) {
         .val()
         .trim();
       visibility['max_file_size'] = $('#max_file_size').val().trim();
-      visibility['file_type_icon'] = $('#file_type_icon').val().trim();
       visibility['delete_enabled'] = $('#delete_enabled').is(':checked');
       visibility['display_layout'] = $('#display_layout').val();
       visibility['auto_upload'] = $('#auto_upload').is(':checked');
diff --git a/dt-core/admin/menu/tabs/tab-custom-fields.php b/dt-core/admin/menu/tabs/tab-custom-fields.php
@@ -545,9 +545,19 @@ private function edit_field( $field_key, $post_type ){
             <?php
                 $custom_fields = dt_get_option( 'dt_field_customizations' );
                 $custom_field = $custom_fields[ $post_type ][ $field_key ] ?? [];
-                $accepted_file_types = $custom_field['accepted_file_types'] ?? [ 'image/*', 'application/pdf' ];
+                $accepted_file_types = $custom_field['accepted_file_types'] ?? [
+                    'image/*',
+                    'application/pdf',
+                    'audio/*',
+                    'video/*',
+                    'application/msword',
+                    'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
+                    'application/vnd.ms-excel',
+                    'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+                    'text/plain',
+                    'text/markdown',
+                ];
                 $max_file_size = $custom_field['max_file_size'] ?? '';
-                $file_type_icon = $custom_field['file_type_icon'] ?? '';
                 $delete_enabled = isset( $custom_field['delete_enabled'] ) ? $custom_field['delete_enabled'] : true;
                 $display_layout = $custom_field['display_layout'] ?? 'grid';
                 $auto_upload = isset( $custom_field['auto_upload'] ) ? $custom_field['auto_upload'] : true;
@@ -564,10 +574,13 @@ private function edit_field( $field_key, $post_type ){
                     <td>
                         <input type="text" name="accepted_file_types" id="accepted_file_types"
                                value="<?php echo esc_attr( implode( ', ', $accepted_file_types ) ) ?>"
-                               placeholder="e.g., image/*, application/pdf, .doc, .docx"
+                               placeholder="e.g., image/*, audio/*, video/*, application/pdf, .docx"
                                style="width: 100%;" />
                         <p style="font-size: 11px; color: #666; margin-top: 5px;">
-                            <?php esc_html_e( 'Comma-separated list of MIME types or file extensions (e.g., image/*, application/pdf, .doc)', 'disciple_tools' ) ?>
+                            <?php esc_html_e( 'Optional. Comma-separated list of MIME types or file extensions to override the default set (images, PDFs, audio, video, common documents). Leave empty to use the default types.', 'disciple_tools' ); ?>
+                            <a href="<?php echo esc_url( 'https://developer.mozilla.org/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types' ); ?>" target="_blank" rel="noopener noreferrer">
+                                <?php esc_html_e( 'View common MIME types.', 'disciple_tools' ); ?>
+                            </a>
                         </p>
                     </td>
                 </tr>
@@ -582,41 +595,6 @@ private function edit_field( $field_key, $post_type ){
                                placeholder="<?php esc_attr_e( 'Leave empty for no limit', 'disciple_tools' ) ?>" />
                     </td>
                 </tr>
-                <tr>
-                    <td style="vertical-align: middle">
-                        <label for="file_type_icon"><b><?php esc_html_e( 'File Type Icon', 'disciple_tools' ) ?></b></label>
-                    </td>
-                    <td>
-                        <table>
-                            <tbody>
-                            <tr>
-                                <td>
-                                    <?php if ( !empty( $file_type_icon ) ) : ?>
-                                        <?php if ( strpos( $file_type_icon, 'mdi' ) === 0 || strpos( $file_type_icon, 'mdi mdi-' ) === 0 ) : ?>
-                                            <i class="<?php echo esc_attr( $file_type_icon ); ?>" style="font-size: 20px; vertical-align: middle;"></i>
-                                        <?php else : ?>
-                                            <img src="<?php echo esc_attr( $file_type_icon ); ?>" style="width: 20px; vertical-align: middle;">
-                                        <?php endif; ?>
-                                    <?php endif; ?>
-                                </td>
-                                <td>
-                                    <input type="text" name="file_type_icon" id="file_type_icon"
-                                           placeholder="<?php esc_attr_e( 'Icon url', 'disciple_tools' ); ?>"
-                                           value="<?php echo esc_attr( $file_type_icon ); ?>">
-                                </td>
-                                <td>
-                                    <button class="button change-icon-button"
-                                            data-form="<?php echo esc_html( $form_name ) ?>"
-                                            data-icon-input="file_type_icon"><?php esc_html_e( 'Change Icon', 'disciple_tools' ); ?></button>
-                                </td>
-                            </tr>
-                            </tbody>
-                        </table>
-                        <p style="font-size: 11px; color: #666; margin-top: 5px;">
-                            <?php esc_html_e( 'Icon to display for non-image files (e.g., PDFs, documents)', 'disciple_tools' ) ?>
-                        </p>
-                    </td>
-                </tr>
                 <tr>
                     <td style="vertical-align: middle">
                         <b><?php esc_html_e( 'Delete Enabled', 'disciple_tools' ) ?></b>
@@ -1069,9 +1047,15 @@ private function process_edit_field( $post_submission ){
             // file_upload field options
             if ( $field['type'] === 'file_upload' ) {
                 // Accepted file types
-                if ( isset( $post_submission['accepted_file_types'] ) && !empty( $post_submission['accepted_file_types'] ) ) {
-                    $types = array_map( 'sanitize_text_field', array_map( 'trim', explode( ',', $post_submission['accepted_file_types'] ) ) );
-                    $custom_field['accepted_file_types'] = $types;
+                if ( isset( $post_submission['accepted_file_types'] ) ) {
+                    $raw_accepted = trim( $post_submission['accepted_file_types'] );
+                    if ( $raw_accepted === '' ) {
+                        // Clear any previously saved override so defaults are used
+                        unset( $custom_field['accepted_file_types'] );
+                    } else {
+                        $types = array_map( 'sanitize_text_field', array_map( 'trim', explode( ',', $raw_accepted ) ) );
+                        $custom_field['accepted_file_types'] = $types;
+                    }
                 }
 
                 // Max file size
@@ -1081,16 +1065,6 @@ private function process_edit_field( $post_submission ){
                     unset( $custom_field['max_file_size'] );
                 }
 
-                // File type icon
-                if ( isset( $post_submission['file_type_icon'] ) ) {
-                    $file_type_icon = sanitize_text_field( wp_unslash( $post_submission['file_type_icon'] ) );
-                    if ( !empty( $file_type_icon ) ) {
-                        $custom_field['file_type_icon'] = $file_type_icon;
-                    } else {
-                        unset( $custom_field['file_type_icon'] );
-                    }
-                }
-
                 // Delete enabled
                 if ( isset( $post_submission['delete_enabled'] ) ) {
                     $custom_field['delete_enabled'] = true;
diff --git a/dt-core/utilities/dt-components.php b/dt-core/utilities/dt-components.php
@@ -332,11 +332,21 @@ public static function render_file_upload( $field_key, $fields, $post, $params =
         }
 
         // Get field settings for configuration
-        $accepted_file_types = $fields[ $field_key ]['accepted_file_types'] ?? [ 'image/*', 'application/pdf' ];
+        $accepted_file_types = $fields[ $field_key ]['accepted_file_types'] ?? [
+            'image/*',
+            'application/pdf',
+            'audio/*',
+            'video/*',
+            'application/msword',
+            'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
+            'application/vnd.ms-excel',
+            'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+            'text/plain',
+            'text/markdown',
+        ];
         $max_file_size = $fields[$field_key]['max_file_size'] ?? null;
         $delete_enabled = isset( $fields[$field_key]['delete_enabled'] ) ? $fields[$field_key]['delete_enabled'] : true;
         $display_layout = $fields[$field_key]['display_layout'] ?? 'grid';
-        $file_type_icon = $fields[$field_key]['file_type_icon'] ?? '';
         $auto_upload = isset( $fields[$field_key]['auto_upload'] ) ? $fields[$field_key]['auto_upload'] : true;
         $download_enabled = isset( $fields[$field_key]['download_enabled'] ) ? $fields[$field_key]['download_enabled'] : true;
         $rename_enabled = isset( $fields[$field_key]['rename_enabled'] ) ? $fields[$field_key]['rename_enabled'] : true;
@@ -417,9 +427,6 @@ public static function render_file_upload( $field_key, $fields, $post, $params =
                 delete-enabled="false"
             <?php endif; ?>
             display-layout="<?php echo esc_attr( $display_layout ) ?>"
-            <?php if ( $file_type_icon ): ?>
-                file-type-icon="<?php echo esc_attr( $file_type_icon ) ?>"
-            <?php endif; ?>
             auto-upload="<?php echo $auto_upload ? 'true' : 'false' ?>"
             <?php if ( !$download_enabled ): ?>
                 download-enabled="false"
