Skip to content

Commit 7d9282a

Browse files
authored
Adjust home screen bottom navigation height and padding (#2904)
* Adjust home screen bottom navigation height and padding - Increase `--launcher-bottom-nav-height` to 86px to ensure consistent layout, replacing a min-height that was not tracked in a variable, producing inconsistent bottom padding. - Update wrapper padding and simplify selectors to provide better scroll clearance for the bottom navigation bar. * Adjust some more nav height * Update package.json to match installed component version * attempt lightningcss config adjustment to fix CI * Change CI to run Vite version from package.json definition Update to v8 is causing errors * CSS variable fallback fix for consistency
1 parent 3ef0f45 commit 7d9282a

File tree

5 files changed

+250
-13
lines changed

5 files changed

+250
-13
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
with:
3838
node-version: 22.x
3939
cache: 'npm'
40-
- run: npm install -g vite eslint @babel/eslint-parser
40+
- run: npm install -g eslint @babel/eslint-parser
4141

4242
- name: Install PHP
4343
uses: shivammathur/setup-php@master
@@ -118,8 +118,8 @@ jobs:
118118
if: steps.changed-css-js-files.outputs.all_changed_and_modified_files != ''
119119
run : |
120120
find dt-assets/ -iname "*.min.js" -or -iname "*.map" -or -iname "*.min.css" -delete && rm -rf build/
121-
vite build
122-
vite build --config vite.config.scripts.js
121+
npx vite build
122+
npx vite build --config vite.config.scripts.js
123123
git diff --exit-code -- . ':(exclude)package-lock.json'
124124
125125
- name: Install Subversion

dt-apps/dt-home/assets/css/home-screen.css

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
--success-color: #4caf50;
1919
--black: #000000;
2020
--app-icon-default: #0a0a0a;
21-
--launcher-bottom-nav-height: 58px;
21+
--launcher-bottom-nav-height: 65px;
2222
--max-bottom-width: 800px;
2323
--nav-home-bg-dark: #3a4fb8;
2424
--nav-text-white: #ffffff;
@@ -978,7 +978,7 @@ body.launcher {
978978
width: 100%;
979979
overflow: hidden;
980980
position: relative;
981-
padding-bottom: var(--launcher-bottom-nav-height, 70px);
981+
padding-bottom: var(--launcher-bottom-nav-height, 58px);
982982
}
983983

984984
.launcher-iframe-container iframe {
@@ -994,7 +994,6 @@ body.launcher {
994994
left: 0;
995995
right: 0;
996996
height: var(--launcher-bottom-nav-height, 58px);
997-
min-height: 86px;
998997
width: 100%;
999998
z-index: 1000;
1000999
background-color: var(--surface-0, #ffffff);
@@ -1008,7 +1007,6 @@ body.launcher {
10081007

10091008
.nav-container {
10101009
height: var(--launcher-bottom-nav-height, 58px);
1011-
min-height: 86px;
10121010
width: 100%;
10131011
max-width: var(--max-bottom-width, 800px);
10141012
display: flex;
@@ -1170,7 +1168,6 @@ body.launcher {
11701168
}
11711169
}
11721170

1173-
body:has(.dt-launcher-bottom-nav),
11741171
#wrapper:has(.dt-launcher-bottom-nav) {
11751172
padding-bottom: var(--launcher-bottom-nav-height, 58px);
11761173
}

package-lock.json

Lines changed: 241 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"devDependencies": {
1414
"@babel/eslint-parser": "^7.28.4",
1515
"@babel/preset-env": "^7.28.3",
16-
"@disciple.tools/web-components": "^0.8.9",
16+
"@disciple.tools/web-components": "^0.8.10",
1717
"@eslint/js": "^9.37.0",
1818
"@kucrut/vite-for-wp": "^0.12.0",
1919
"@rollup/plugin-inject": "^5.0.5",

vite.config.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ export default defineConfig(({ mode }) => {
8181
}),
8282
],
8383
css: {
84+
lightningcss: {
85+
errorRecovery: true,
86+
},
8487
preprocessorOptions: {
8588
scss: {
8689
api: 'modern-compiler',

0 commit comments

Comments
 (0)