Duplicates: don't show already closed duplicate contacts (#2750)

* Enhance duplicate checking by adding 'ignore_archived' parameter to API calls

                - Updated the API call in contacts.js to include an 'ignore_archived' option when fetching duplicates.
                - Modified the duplicates-merging.php to handle the new parameter, allowing for more refined duplicate searches by excluding archived records.

* Refactor API call formatting in contacts.js for improved readability

                - Updated the formatting of the API call to get duplicates, enhancing code clarity by aligning parameters and removing unnecessary line breaks.

* Refactor duplicate checking API calls to remove 'ignore_archived' parameter

                - Simplified the API call in contacts.js by removing the 'ignore_archived' parameter when fetching duplicates.
                - Updated duplicates-merging.php to reflect this change, ensuring consistent handling of duplicate searches without the archived status filter.

* Refactor API call formatting in contacts.js for improved readability

                                - Enhanced the formatting of the API call to get duplicates by aligning parameters and removing unnecessary line breaks for better clarity.
                                - Updated the promise handling to improve code structure and maintainability.

* Refactor duplicate search logic in duplicates-merging.php

                - Updated the method for querying duplicate searches to use get_post_field_settings for improved clarity.
                - Simplified the construction of search queries by directly assigning values to the search_query array.
                - Added logic to filter out already merged records from the duplicate checks, ensuring that only relevant duplicates are processed.
                - Enhanced SQL query to exclude posts marked as 'duplicate' in the reason_closed field, improving the accuracy of duplicate detection.

* Refactor condition check in duplicates-merging.php for improved readability

                - Updated the condition for excluding merged records to enhance clarity by adjusting spacing in the array syntax.
                - Ensured consistent formatting in the logic that filters out already processed duplicates.

* fix phpcs

Author: kodinkat

dt-contacts/duplicates-merging.php

@@ -141,6 +141,7 @@ public static function ids_of_non_dismissed_duplicates( $post_type, $post_id, $e
         if ( is_wp_error( $post ) ){
             return $post;
         }
+        global $wpdb;
         $search_query = self::query_for_duplicate_searches( $post_type, $post_id, $exact );
         $res = DT_Posts::search_viewable_post( 'contacts', [ $search_query['query'] ] );
         if ( is_wp_error( $res ) ){
@@ -156,6 +157,30 @@ public static function ids_of_non_dismissed_duplicates( $post_type, $post_id, $e
         //exclude already dismissed duplicates and self
         $ids = array_values( array_diff( $ids, array_merge( $dismissed, [ $post_id ] ) ) );
 
+        //ignore already merged records
+        if ( $post_type === 'contacts' && !empty( $ids ) ) {
+
+            $ids_sql = dt_array_to_sql( $ids );
+            $sql = "
+            SELECT DISTINCT p.ID as post_id
+            FROM $wpdb->posts p
+            WHERE p.ID IN ( $ids_sql )
+            AND p.post_type = 'contacts'
+            AND NOT EXISTS (
+                SELECT 1
+                FROM $wpdb->postmeta pm
+                WHERE pm.post_id = p.ID
+                AND pm.meta_key = 'reason_closed'
+                AND pm.meta_value = 'duplicate'
+            )
+            ";
+
+            $filtered_ids = $wpdb->get_results( $sql, ARRAY_A ); //phpcs:ignore
+
+            // Update the ids array with only the filtered results
+            $ids = array_column( $filtered_ids, 'post_id' );
+        }
+
         return [
             'ids' => $ids
         ];
@@ -199,6 +224,9 @@ public static function get_all_duplicates_on_post( $post_type, $post_id ){
             if ( $possible_duplicate['ID'] === $post_id || in_array( $possible_duplicate['ID'], $ids ) ){
                 continue; // exclude self and records already processed
             }
+            if ( isset( $possible_duplicate['overall_status']['key'], $possible_duplicate['reason_closed']['key'] ) && in_array( $possible_duplicate['overall_status']['key'], [ 'closed' ] ) && in_array( $possible_duplicate['reason_closed']['key'], [ 'duplicate' ] ) ) {
+                continue; // exclude merged records
+            }
             $ids[] = $possible_duplicate['ID'];
             $match_on = [];
             $points = 0;