Support New DT-Import Non-Overwrite Setting

[kodinkat]

No description provided.

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)

• dt-posts/dt-posts-endpoints.php: Language not supported
• dt-posts/dt-posts-hooks.php: Language not supported
• dt-posts/dt-posts.php: Language not supported

[corsacca]

@kodinkat does dt_ignore_duplicated_post_fields check if the 2 values are different or if any value exists on the existing record? I'm having trouble following the logic.
The previous behavior is that all fields are updated.
The new behavior:

• for single values fields: we don't update the field if it already has a value
• for multiple value fields: we only add new values if they don't already exist

Does that sound right?

[corsacca]

I'm curious about adding this feature to the update_post function. Something like do_not_overwrite_exsting_fields param is past in, then it does the check there.

We'll also need to write some unit tests for this. AI should be good at this part.

[kodinkat]

@kodinkat does dt_ignore_duplicated_post_fields check if the 2 values are different or if any value exists on the existing record? I'm having trouble following the logic. The previous behavior is that all fields are updated. The new behavior:

• for single values fields: we don't update the field if it already has a value
• for multiple value fields: we only add new values if they don't already exist

Does that sound right?

This is correct, as new logic only updates/adds value if field does not already contain it. Therefore, ignoring any duplicates.

[kodinkat]

I'm curious about adding this feature to the update_post function. Something like do_not_overwrite_exsting_fields param is past in, then it does the check there.

We'll also need to write some unit tests for this. AI should be good at this part.

Sounds good, maybe tackle as a new ticket, once functionality has been merged in?

[corsacca]

On this one lets go slower.
Lets move the do not overwrite to the update post
and lets create unit tests to check that things are working as expected.

[kodinkat]

@corsacca pls see latest shape and let me know if this holds up for you...

[corsacca]

@kodinkat can you make sure there are tests for each field type?

[corsacca]

@kodinkat

A clarification.

$original = [
"name" => "bob",
"phone" => "1234"
]

$update = [
"name" => "Fred",
"phone" => "2903",
"email" => "test@test.com"
]

The results should be

[
"name" => "bob",
"phone" => "1234",
"email" => "test@test.com"
]

Because we have the "dont_overwrite_existing_fields" set to true.

Right now the result is

[
"name" => "Fred",
"phone" => "2903",
"email" => "test@test.com"
]

[kodinkat]

@corsacca see latest updates; which should now produce the desired shape.

[corsacca]

@kodinkat The same thing applies for all the other fields too. For example date is being updated even if original has a date.
Please have a look at each field

[kodinkat]

@corsacca Below is a summary of the logic now adopted across the different field types, when do_not_overwrite_existing_fields flag is enabled.

The following field types, will only be allowed to update, if no existing values are detected.

• text
• textarea
• number
• boolean
• date
• key_select

The following field types, will only be allowed to update, if no matching options are detected. However, non-matching options could also exist.

• tags
• multi_select
• location
• location_meta
• communication_channel

Also, just to highlight, as the do_not_overwrite_existing_fields flag is enabled by default on both create_post & update_post endpoints; the above conditions will prevent some direct manual record field updates.

[corsacca]

@kodinkat Missing tests for multi_select, user_select, connection.
I started the multi_select and user_select to the create, but it is getting on error.
Also a couple fixes.
Would you be able to add the missing ones please?

[corsacca]

Thank you @kodinkat!

[cursor]

Bug: Field Overwrite Bug in `dt_ignore_duplicated_post_fields`

The dt_ignore_duplicated_post_fields function incorrectly uses empty() to determine if existing field values should be preserved. This causes valid falsy values (e.g., boolean false, number 0, or string '0' for key_select fields) to be treated as empty and overwritten, even when do_not_overwrite_existing_fields is enabled. The check should verify if the field is unset or null instead.

dt-posts/posts.php#L3179-L3182

disciple-tools-theme/dt-posts/posts.php

Lines 3179 to 3182 in f2b999e

	case 'user_select':
	if ( empty( $existing_fields[ $field_key ] ) ) {
	$updated_fields[ $field_key ] = $field_value;
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎