Skip to content

#2666 - Resolve CSV Export All Fields Bug #2669

Merged
corsacca merged 1 commit into
DiscipleTools:developfrom
kodinkat:2666-resolve-csv-export-all-fields-bug
Apr 10, 2025
Merged

#2666 - Resolve CSV Export All Fields Bug #2669
corsacca merged 1 commit into
DiscipleTools:developfrom
kodinkat:2666-resolve-csv-export-all-fields-bug

Conversation

@kodinkat
Copy link
Copy Markdown
Collaborator

@corsacca corsacca requested a review from Copilot April 10, 2025 13:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

dt-assets/js/modular-list.js:4329

  • Changing from an equality check to a less-than-or-equal check may allow rows with incomplete data to be exported. Verify that this behavior correctly addresses the bug without introducing new issues related to missing fields.
if (csv_row.length <= exporting_fields.length + 1) {

@corsacca
Copy link
Copy Markdown
Member

Brilliant!

@corsacca corsacca merged commit ae35e35 into DiscipleTools:develop Apr 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve CSV Export All Fields Bug

3 participants