#2666 - Resolve CSV Export All Fields Bug #2669
Merged
corsacca merged 1 commit intoApr 10, 2025
Merged
Conversation
Collaborator
kodinkat
commented
Apr 10, 2025
- fixes: Resolve CSV Export All Fields Bug #2666
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
dt-assets/js/modular-list.js:4329
- Changing from an equality check to a less-than-or-equal check may allow rows with incomplete data to be exported. Verify that this behavior correctly addresses the bug without introducing new issues related to missing fields.
if (csv_row.length <= exporting_fields.length + 1) {
Member
|
Brilliant! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.